London | 26-March-SDC | Ammad Ur Rehman | Sprint 1 | Individual Shell Tools#420
London | 26-March-SDC | Ammad Ur Rehman | Sprint 1 | Individual Shell Tools#420anosidium wants to merge 6 commits into
Conversation
anosidium
added
the
Needs Review
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Could you adjust the settings of your editor and adjust all the scripts, they are missing the trailing new line
| # Line 3 should be "It contains many lines, and there are some things you may want to do with each of them.". | ||
| # Line 11 should be "We also should remember, when we go shopping, to get 4 items: oranges, cheese, bread, olives.". | ||
|
|
||
| sed -E 's/,([^ ])/\, \1/g' input.txt No newline at end of file |
There was a problem hiding this comment.
Do we need to escape comma via ","?
| @@ -16,8 +16,12 @@ echo "First exercise (sorted newest to oldest):" | |||
| # TODO: Write a command which lists the files in the child-directory directory, one per line, sorted so that the most recently modified file is first. | |||
There was a problem hiding this comment.
Does the approach output one-per-line in this script?
| # I was tempted to take a bite of it. | ||
| # But this seemed like a bad idea... | ||
|
|
||
| cat ../helper-files/helper-1.txt ../helper-files/helper-2.txt ../helper-files/helper-3.txt No newline at end of file |
There was a problem hiding this comment.
Do we need to list all the files manually if the task asks tou output all the files inside the directory?
SlideGauge
added
Reviewed
Thanks for the review. Before I address the rest of your comments, could you tell me a bit more about how to do this? Are you referring to the “No newline at end of file”? My other pull requests have had the same thing, so this is the first time I’ve heard it mentioned. |
|
Yeah, I'm talking about |
2 participants
Learners, PR Template
Self checklist
Changelist
Done all the required exercise with some stretch exercises completed
Questions
I find reading the manual pages of the commands confusing and looking them up on the internet isn’t much better either.