London | 26-Mar-SDC | Onur Atas | Sprint 5| prep exercises#532
Conversation
onurat
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
I think you may have submitted the wrong files here, do you want to take another look?
LonMcGregor
added
Reviewed
|
I made a mistake on the branching. This has all that's been done so far for the tools module. I believe only the prep exercises folder needs reviewing. Or you can look at this commit sha 0b59f61 |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on the prep exercises.
I've left a couple of comments to guide you to a more complete solution.
It would be best if you can remove the unneeded files from this branch, otherwise we can't accept this PR as complete.
| @@ -0,0 +1,35 @@ | |||
| from datetime import date | |||
|
|
|||
There was a problem hiding this comment.
Part of the methods task included giving an explanation of the differences between methods and functions. Can you give a brief explanation?
| age = int(input("Age: ")) | ||
| except ValueError: | ||
| print("Invalid age", file=sys.stderr) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Instead of exiting immediately, is there a way you could re-ask for correct input?
2 participants
Self checklist
Changelist
Completed all Sprint 5 prep exercises:
Tested all exercises locally.
Note:
person_class.pyintentionally contains an invalid property access (person.address) because the exercise required demonstrating that mypy can detect access to a property that does not exist.