Open
Conversation
tgvashworth
force-pushed
the
impl/docker-cloud
branch
3 times, most recently
from
14ce468 to
2719a9d
Compare
tgvashworth
force-pushed
the
impl/docker-cloud
branch
6 times, most recently
from
684c195 to
28aa11b
Compare
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looks great - I think this is an achievable amount of work, and covers a good amount of functionality to be both approachable and useful.
(I'm not sure how much to be "useful wording/grammar" reviewing IMPLEMENTATION.mds absent README.mds... Did some review!)
docker-cloud/main_test.go
Outdated
Comment on lines
+44
to
+45
| t.Log(resource.GetPort("8080/tcp")) | ||
| resp, err = http.Get(fmt.Sprint("http://localhost:", resource.GetPort("8080/tcp"), "/ping")) |
Member
There was a problem hiding this comment.
Suggested change
| t.Log(resource.GetPort("8080/tcp")) | |
| resp, err = http.Get(fmt.Sprint("http://localhost:", resource.GetPort("8080/tcp"), "/ping")) | |
| port := resource.GetPort("8080/tcp") | |
| t.Log(port) | |
| resp, err = http.Get(fmt.Sprint("http://localhost:", port, "/ping")) |
tgvashworth
force-pushed
the
impl/docker-cloud
branch
from
7350649 to
fec9de7
Compare
To accelerate this project, we'll begin with a set of tutorials which introduce the concepts with real-world use. Just this will take several hours for someone who hasn't done this before. Then the project will be to bring it all together: the implementation will do this, hopefully also including CI/CD.
workflow_dispatch does not work becuase the workflow file is not on the main branch yet.
tgvashworth
force-pushed
the
impl/docker-cloud
branch
from
fec9de7 to
3a076d5
Compare
tgvashworth
force-pushed
the
impl/docker-cloud
branch
from
d564272 to
9ba14c3
Compare
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
tgvashworth
force-pushed
the
impl/docker-cloud
branch
from
a8f488c to
820d4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the README.md commit for the
mainbranch which will be rebased out once #38 is merged.View rendered README.md
View rendered docker-cloud/IMPLEMENTATION.md
View rendered docker-cloud/README.md