Open
Conversation
This commit does quite a bit: - Introduces Makefile as the commands are getting long - Adds installation of ImageMagick to the Dockerfile - Adds imagick bindings - Instatiates the bindings in main.go to check they work
tgvashworth
force-pushed
the
impl/batch-processing-2
branch
from
ba7c147 to
5a0d78f
Compare
illicitonion
reviewed
Oct 3, 2022
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Generally looks like a good shape :) I'm assuming it'll be come more goroutine-based at some point? I definitely like the breaking up of IO-bound and CPU-bound work into separate goroutine pools :)
| defer res.Body.Close() | ||
|
|
||
| // Ensure we got success from the server | ||
| if res.StatusCode != http.StatusOK { |
Member
There was a problem hiding this comment.
As an extension problem in the README, I'd add trying to get them thinking about pause/resume, so that already-done work can be skipped if we end up re-running (i.e. if the processed failed, we somehow have tracked what we've already processed, so we can just pick up the not-yet-done work). But not for the first cut!
However, for the example impl I'd probably add a comment here contrasting the pros of eagerly failing vs log and continue
- The `defer` calls now clean up immediately - New `Config` and `Row` structs clean up the flow
tgvashworth
force-pushed
the
impl/batch-processing-2
branch
from
72910a0 to
022f41a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #26.
View rendered batch-processing/IMPLEMENTATION.md