Skip to content

Commit 63463b5

Browse files
authored
permit gitignore changes (#51)
The file change checker blocks top-level gitignore changes. We should not do that. in theory we could force trainees to only make changes to a gitignore in the specific sprint directory when required, but I think that might be overly punishing. --------- Co-authored-by: l <l>
1 parent 4585cad commit 63463b5

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/bin/pr-metadata-validator.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,9 @@ async fn check_pr_file_changes(
309309

310310
// check each file and error if one is in unexpected place
311311
for pr_file in pr_files {
312+
if pr_file.filename == ".gitignore" {
313+
continue; // always allow top-level gitignore changes
314+
}
312315
if !directory_matcher.is_match(&pr_file.filename) {
313316
return Ok(ValidationResult::WrongFiles {
314317
expected_files_pattern: directory_description_regex.to_string(),

0 commit comments

Comments
 (0)