remove taking ownership from sprint vec iter

Author: l

src/bin/pr-metadata-validator.rs

@@ -252,7 +252,7 @@ async fn validate_pr(
     }
 
     let pr_assignment_descriptor_id =
-        get_descriptor_id_for_pr(matched.sprints, pr_number).expect("This PR does not exist");
+        get_descriptor_id_for_pr(&matched.sprints, pr_number).expect("This PR does not exist");
     // This should never error, as a PR by this point in code must have been matched
     // with an assignment, and PR assignments must have an associated issue descriptor
 

src/course.rs

@@ -1021,12 +1021,12 @@ fn match_pr_to_assignment(
 // Given a vector of sprints, and a target pr number, for a given person
 // return the issue ID for the associated assignment descriptor
 pub fn get_descriptor_id_for_pr(
-    sprints: Vec<SprintWithSubmissions>,
+    sprints: &[SprintWithSubmissions],
     target_pr_number: u64,
 ) -> Option<u64> {
     match sprints
         .iter()
-        .flat_map(|sprint_with_subs| sprint_with_subs.submissions.clone())
+        .flat_map(|sprint_with_subs| sprint_with_subs.submissions.iter())
         .filter_map(|missing_or_submission| match missing_or_submission {
             SubmissionState::Some(s) => Some(s),
             _ => None,
@@ -1038,7 +1038,7 @@ pub fn get_descriptor_id_for_pr(
         Some(Submission::PullRequest {
             assignment_issue_id,
             ..
-        }) => Some(assignment_issue_id),
+        }) => Some(*assignment_issue_id),
         _ => None, // Was called with a nonexistent PR number, can't find an associated assignment
     }
 }