Only error on multi-sprint issues that need submitting#46
Merged
Conversation
Check whether it needs submitting _before_ checking for number of sprints, rather than after. This also starts erroring if things don't have a Submit: label, because they all do now, and it makes the code simpler.
LonMcGregor
reviewed
Dec 17, 2025
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, This seems like a good change, if issues are going to potentially have more than one sprint label attached to them. Forcing more checks for having the right labels should make it easier to spot issues that are not properly labelled and make it easier to organise / fix them.
I am a bit confused about the final part of this change, and i've left a comment there.
LonMcGregor
approved these changes
Dec 17, 2025
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This looks all good, thanks for the explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether it needs submitting before checking for number of sprints, rather than after.
This also starts erroring if things don't have a Submit: label, because they all do now, and it makes the code simpler.