dev: upgrade phpcs and add phpstan

- Upgrade PHPCS
- Add PHPStan with LV 6 baseline
- Fixed some issues reported by PHPCS and PHPStan

Since there are numerous issues with PHPStan, a baseline has been added for the existing issues. When an old problem is solved, PHPStan will report it, and the baseline needs to be regenerated.

Author: Soare-Robert-Daniel

.distignore

@@ -42,3 +42,5 @@ docker-compose.travis.yml
 docker-compose.ci.yml
 .wp-env.json
 artifacts
+phpstan.neon
+phpstan-baseline.neon

.github/workflows/test-e2e.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "npm"
       - name: Install npm deps
         run: |

.github/workflows/test-lint-js.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "npm"
       - name: Install Dependencies
         run: npm install

.github/workflows/test-php.yml

@@ -25,6 +25,23 @@ jobs:
       - name: Run PHPCS
         run: composer run lint
 
+  phpstan:
+    name: PHPStan
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup PHP version
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "7.4"
+          extensions: simplexml
+      - name: Checkout source code
+        uses: actions/checkout@v4
+      - name: Install composer
+        run: |
+          composer install --prefer-dist --no-progress
+      - name: Run phpstan
+        run: composer run phpstan
+
   phpunit:
     name: PHPUnit
     runs-on: ubuntu-latest

composer.json

@@ -31,7 +31,9 @@
   "scripts": {
     "format": "phpcbf --standard=phpcs.xml --report-summary --report-source",
     "lint": "phpcs --standard=phpcs.xml",
-    "test": "phpunit"
+    "test": "phpunit",
+    "phpstan": "phpstan",
+    "phpstan:generate:baseline": "phpstan --generate-baseline"
   },
   "minimum-stability": "dev",
   "prefer-stable": true,
@@ -48,6 +50,9 @@
     "wp-coding-standards/wpcs": "^3.1",
     "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
     "phpcompatibility/phpcompatibility-wp": "^2.1",
-    "yoast/phpunit-polyfills": "^4.0"
+    "yoast/phpunit-polyfills": "^4.0",
+    "automattic/vipwpcs": "^3.0",
+    "phpstan/phpstan": "^1.12",
+    "szepeviktor/phpstan-wordpress": "^1.3"
   }
 }