Skip to content

Commit 75e4f52

Browse files
fix: default values
1 parent bce84dd commit 75e4f52

3 files changed

Lines changed: 10 additions & 15 deletions

File tree

includes/gutenberg/feedzy-rss-feeds-loop-block.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ public function render_callback( $attributes, $content ) {
138138
'target' => '_blank',
139139
'keywords_ban' => '',
140140
'columns' => '1',
141-
'thumb' => $thumb,
142-
'default' => $default_thumbnail_img,
141+
'thumb' => 'no',
142+
'default' => '',
143143
'title' => '',
144144
'meta' => 'yes',
145145
'multiple_meta' => 'no',
@@ -295,7 +295,7 @@ private function get_thumbnail( $item, $attributes ) {
295295
return $item['item_img_path'];
296296
}
297297

298-
if ( 'yes' !== $thumb ) {
298+
if ( 'auto' === $thumb ) {
299299
return '';
300300
}
301301

@@ -309,7 +309,12 @@ private function get_thumbnail( $item, $attributes ) {
309309
isset( $settings, $settings['general'], $settings['general']['default-thumbnail-id'] ) &&
310310
! empty( $settings['general']['default-thumbnail-id'] )
311311
) {
312-
return wp_get_attachment_image_src( $settings['general']['default-thumbnail-id'], 'full' );
312+
$media_img = wp_get_attachment_image_src( $settings['general']['default-thumbnail-id'], 'full' );
313+
if (
314+
is_array( $media_img ) && ! empty( $media_img[0] )
315+
) {
316+
return $media_img[0];
317+
}
313318
}
314319

315320
return FEEDZY_ABSURL . 'img/feedzy.svg';

js/FeedzyLoop/block.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
},
5858
"thumb": {
5959
"type": "string",
60-
"default": "auto"
60+
"default": "yes"
6161
},
6262
"fallbackImage": {
6363
"type": "object"

phpstan-baseline.neon

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,21 +1635,11 @@ parameters:
16351635
count: 1
16361636
path: includes/gutenberg/feedzy-rss-feeds-loop-block.php
16371637

1638-
-
1639-
message: "#^Method Feedzy_Rss_Feeds_Loop_Block\\:\\:get_value\\(\\) has parameter \\$item with no value type specified in iterable type array\\.$#"
1640-
count: 1
1641-
path: includes/gutenberg/feedzy-rss-feeds-loop-block.php
1642-
16431638
-
16441639
message: "#^Method Feedzy_Rss_Feeds_Loop_Block\\:\\:register_block\\(\\) has no return type specified\\.$#"
16451640
count: 1
16461641
path: includes/gutenberg/feedzy-rss-feeds-loop-block.php
16471642

1648-
-
1649-
message: "#^Method Feedzy_Rss_Feeds_Loop_Block\\:\\:render_callback\\(\\) has parameter \\$attributes with no value type specified in iterable type array\\.$#"
1650-
count: 1
1651-
path: includes/gutenberg/feedzy-rss-feeds-loop-block.php
1652-
16531643
-
16541644
message: "#^Offset 1 on array\\{string, non\\-empty\\-string\\} in isset\\(\\) always exists and is not nullable\\.$#"
16551645
count: 1

0 commit comments

Comments
 (0)