chore: fix clean up test

Author: Soare-Robert-Daniel

includes/admin/feedzy-rss-feeds-log.php

@@ -536,18 +536,21 @@ function ( $line ) {
 	 * Delete the log file if it is older than 14 days or if the size exceeds the maximum allowed size.
 	 *
 	 * @since 5.1.0
-	 * @return void
+	 * @return bool
 	 */
 	public function should_clean_logs() {
-		if (
-			! file_exists( $this->filepath ) ||
-			self::DEFAULT_MAX_FILE_SIZE > $this->get_log_file_size() ||
-			strtotime( '-14 days' ) < filemtime( $this->filepath )
-		) {
-			return;
+		if ( ! file_exists( $this->filepath ) ) {
+			return false;
 		}
-		
-		$this->delete_log_file();
+
+		$is_too_big = $this->get_log_file_size() > self::DEFAULT_MAX_FILE_SIZE;
+		$is_too_old = filemtime( $this->filepath ) < strtotime( '-14 days' );
+
+		if ( $is_too_big || $is_too_old ) {
+			return $this->delete_log_file();
+		}
+
+		return false;
 	}
 
 	/**
@@ -801,7 +804,7 @@ public function reset_log_stats() {
 	 * @since 5.1.0
 	 * @return string The full path to the log file.
 	 */
-	private function get_log_file_path() {
+	public function get_log_file_path() {
 		$upload_dir = wp_upload_dir();
 		$log_dir    = $upload_dir['basedir'] . '/feedzy-logs';
 		return $log_dir . '/' . self::FILE_NAME . self::FILE_EXT;

tests/test-log.php

@@ -462,13 +462,38 @@ public function test_should_clean_logs() {
 		// Create a log file
 		Feedzy_Rss_Feeds_Log::error( 'Test error' );
 		$this->assertTrue( $this->logger->log_file_exists() );
-		
+
+		$file_path = $this->logger->get_log_file_path();
+
+		// Simulate an old log file by setting its modification time far in the past
+		$this->assertTrue( file_exists( $file_path ), 'Log file should exist before aging it' );
+		$old_time = time() - ( defined( 'YEAR_IN_SECONDS' ) ? YEAR_IN_SECONDS : 365 * 24 * 60 * 60 );
+		$this->assertTrue( touch( $file_path, $old_time ), 'Should be able to update mtime to an old timestamp' );
+		clearstatcache( true, $file_path );
+
+		// Old file should be cleaned
+		$this->logger->should_clean_logs();
+		$this->assertFalse( $this->logger->log_file_exists(), 'Old log file should be cleaned (deleted)' );
+
+		// Create a fresh small log again
+		Feedzy_Rss_Feeds_Log::error( 'Recent small error' );
+		$this->assertTrue( $this->logger->log_file_exists(), 'Recent log file should exist' );
+
 		// File is small and recent, should not be cleaned
 		$this->logger->should_clean_logs();
-		$this->assertTrue( $this->logger->log_file_exists() );
-		
-		// Manually modify file time to be old (would require file manipulation)
-		// This is a simplified test - in practice you'd need to mock filemtime()
+		$this->assertTrue( $this->logger->log_file_exists(), 'Recent small log should not be cleaned' );
+
+		// Enlarge the log to exceed the max size and ensure it gets cleaned
+		$fp = fopen( $file_path, 'r+' );
+		$this->assertNotFalse( $fp, 'Should be able to open log file for resizing' );
+		$target_size = Feedzy_Rss_Feeds_Log::DEFAULT_MAX_FILE_SIZE + 1;
+		$this->assertTrue( ftruncate( $fp, $target_size ), 'Should be able to enlarge log file' );
+		fclose( $fp );
+		clearstatcache( true, $file_path );
+		$this->assertGreaterThan( Feedzy_Rss_Feeds_Log::DEFAULT_MAX_FILE_SIZE, filesize( $file_path ), 'Log size should exceed max size' );
+
+		$this->logger->should_clean_logs();
+		$this->assertFalse( $this->logger->log_file_exists(), 'Oversized log file should be cleaned (deleted)' );
 	}
 
 	/**