feat: add aspect ratio control for Feedzy Classic Block#1117
Merged
Conversation
RaduCristianPopescu
added
the
pr-checklist-skip
There was a problem hiding this comment.
Pull Request Overview
This PR adds aspect ratio functionality to the thumbnail image control in the Feedzy RSS feeds plugin, allowing users to control how images are displayed with various aspect ratio options instead of relying only on fixed dimensions.
Key changes:
- Adds new aspect ratio selector control with predefined options (Original, 1:1, 16:9, 4:3, 3:2, 2:1, 3:4)
- Updates both block editor and frontend rendering to use CSS aspect-ratio property
- Replaces background-image spans with proper img elements for better accessibility
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| js/FeedzyBlock/inspector.js | Adds SelectControl for aspect ratio with predefined options |
| js/FeedzyBlock/attributes.js | Defines aspectRatio attribute with default value 'auto' |
| js/FeedzyBlock/Editor.js | Implements aspect ratio handler and updates editor rendering to use img elements |
| includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php | Registers aspectRatio attribute for the block |
| includes/abstract/feedzy-rss-feeds-admin-abstract.php | Updates frontend rendering to apply aspect ratio styles and use img elements |
RaduCristianPopescu
force-pushed
the
feat/aspect-ratio_thumbnail
branch
from
880b755 to
ee1fe1c
Compare
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for 1974b4c is ready 🛎️!
Note You can preview the changes in the Playground |
| // thumbs pixel size. | ||
| 'size' => '', | ||
| // default aspect ratio for the image. | ||
| 'aspectRatio' => 'auto', |
Contributor
There was a problem hiding this comment.
let's make it '1'
| $img_style = ''; | ||
| if ( isset( $sizes['height'] ) ) { | ||
| $img_style = 'height:' . $sizes['height'] . 'px;'; | ||
| if ( isset( $sc['aspectRatio'] ) ) { |
Contributor
There was a problem hiding this comment.
if the aspectRatio is '1' let's keep the backward compatibility by providing the width.
if ( isset( $sc['aspectRatio'] ) && '1' !== $sc['aspectRatio'] ) {
Comment on lines
+1433
to
+1437
| if ( isset( $sc['aspectRatio'] ) ) { | ||
| $img_style .= 'aspect-ratio:' . $sc['aspectRatio'] . ';'; | ||
| } elseif ( isset( $sizes['width'] ) && is_numeric( $sizes['width'] ) ) { | ||
| $img_style .= 'width:' . $sizes['width'] . 'px;'; | ||
| } |
Contributor
There was a problem hiding this comment.
Should not be duplicated
Soare-Robert-Daniel
approved these changes
Aug 6, 2025
RaduCristianPopescu
changed the title
RaduCristianPopescu
force-pushed
the
feat/aspect-ratio_thumbnail
branch
from
0fb37d2 to
1974b4c
Compare
Contributor
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Aspect Ratio Options and Better Dimension Handling for thumbnail image control.
Inspired by WordPress Aspect Ratio's design.
Will affect visual aspect of the product
YES
Screenshots
Editor
Preview
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/883