feat: change the integration upsell label based on the license plan#1130
Merged
Conversation
Contributor
|
Plugin build for ce1cc27 is ready 🛎️!
Note You can preview the changes in the Playground |
| @@ -1,10 +1,14 @@ | |||
| <?php | |||
| $plan = apply_filters( 'product_feedzy_license_plan', 0 ); | |||
Contributor
There was a problem hiding this comment.
I see that $plan is not used. Did you forget to remove it after you started using the filter apply_filters( 'feedzy_is_license_of_type', false, 'business' )?
| @@ -1,10 +1,14 @@ | |||
| <?php | |||
| $plan = apply_filters( 'product_feedzy_license_plan', 0 ); | |||
Contributor
There was a problem hiding this comment.
| @@ -1,10 +1,14 @@ | |||
| <?php | |||
| $plan = apply_filters( 'product_feedzy_license_plan', 0 ); | |||
Contributor
There was a problem hiding this comment.
| @@ -1,16 +1,18 @@ | |||
| <?php | |||
| $plan = apply_filters( 'product_feedzy_license_plan', 0 ); | |||
Contributor
There was a problem hiding this comment.
| @@ -1,10 +1,14 @@ | |||
| <?php | |||
| $plan = apply_filters( 'product_feedzy_license_plan', 0 ); | |||
Contributor
There was a problem hiding this comment.
Soare-Robert-Daniel
requested changes
Aug 11, 2025
Contributor
Soare-Robert-Daniel
left a comment
There was a problem hiding this comment.
Left some mentions about $plan
8e50708 to
ce1cc27
Compare
Contributor
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show the plan-based notice to the integrations
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/851