Skip to content

refactor: UI for Schedule option in Settings#1141

Merged
Soare-Robert-Daniel merged 5 commits into
developmentfrom
refactor/import_schedule
Aug 15, 2025
Merged

refactor: UI for Schedule option in Settings#1141
Soare-Robert-Daniel merged 5 commits into
developmentfrom
refactor/import_schedule

Conversation

@RaduCristianPopescu
Copy link
Copy Markdown
Contributor

@RaduCristianPopescu RaduCristianPopescu commented Aug 14, 2025

Summary

Removed description and changed the title.

Will affect visual aspect of the product

YES

Screenshots

CleanShot 2025-08-14 at 10 55 31@2x

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/914

@RaduCristianPopescu RaduCristianPopescu self-assigned this Aug 14, 2025
@RaduCristianPopescu RaduCristianPopescu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 14, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 14, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the import scheduler interface by changing the label text and removing the help description. The changes focus on improving the visual presentation of the import schedule configuration.

  • Updated the label from "Import schedule" to "Default Importing Schedule"
  • Removed the help text that explained the scheduler functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<div class="fz-form-group">
<label class="form-label"><?php esc_html_e( 'Import schedule', 'feedzy-rss-feeds' ); ?></label>
<label class="form-label"><?php esc_html_e( 'Default Importing Schedule', 'feedzy-rss-feeds' ); ?></label>
<select id="fz-event-schedule" class="form-control fz-select-control" name="feedzy_meta_data[fz_cron_schedule]"<?php disabled( true, ! feedzy_is_pro() ); ?>>
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the help text that explained 'Choose how often Feedzy should import new items from your feeds' may reduce accessibility for users who need context about what the schedule setting does. Consider adding aria-describedby or title attributes to maintain accessibility.

Suggested change
<select id="fz-event-schedule" class="form-control fz-select-control" name="feedzy_meta_data[fz_cron_schedule]"<?php disabled( true, ! feedzy_is_pro() ); ?>>
<label class="form-label" for="fz-event-schedule"><?php esc_html_e( 'Default Importing Schedule', 'feedzy-rss-feeds' ); ?></label>
<div id="fz-schedule-help" class="screen-reader-text">
<?php esc_html_e( 'Choose how often Feedzy should import new items from your feeds.', 'feedzy-rss-feeds' ); ?>
</div>
<select id="fz-event-schedule" class="form-control fz-select-control" name="feedzy_meta_data[fz_cron_schedule]" aria-describedby="fz-schedule-help"<?php disabled( true, ! feedzy_is_pro() ); ?>>

Copilot uses AI. Check for mistakes.
@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Aug 14, 2025

Plugin build for 183d31f is ready 🛎️!

Note

You can preview the changes in the Playground

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title refactor: importing scheduler refactor: UI for Schedule option in Settings Aug 14, 2025
@poonam279
Copy link
Copy Markdown

@Soare-Robert-Daniel, The changes are reflected correctly in the general settings, but shouldn’t they appear the same way in the individual import as well? The per-import schedule setting isn’t displaying "externally created" text with the manually created cron schedule.
cron

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit a0ed1a8 into development Aug 15, 2025
9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/import_schedule branch August 15, 2025 13:09
@pirate-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants