feat: add errors report email frequency#1142
Merged
Merged
Conversation
Soare-Robert-Daniel
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for e9f2935 is ready 🛎️!
Note You can preview the changes in the Playground |
Contributor
Author
|
@ineagu I added a description to the email toggle so that the user can know that it can change the frequency 
Before
|
| if ( | ||
| false !== Feedzy_Rss_Feeds_Util_Scheduler::is_scheduled( 'task_feedzy_cleanup_logs' ) | ||
| ) { | ||
| public function maybe_reschedule_email_report( $old_value, $value, $option ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
Member
There was a problem hiding this comment.
Not the biggest but if the variable is unused we can just remove it.
Contributor
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Will affect visual aspect of the product
YES
Screenshots
Test instructions
If the Action Scheduler is present, you will find the events here:
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/848