feat: add custom cron schedules workflow by RaduCristianPopescu · Pull Request #1144 · Codeinwp/feedzy-rss-feeds

RaduCristianPopescu · 2025-08-14T13:06:04Z

Summary

Added a new tab in Settings, allowing users to create custom cron schedules.

Will affect visual aspect of the product

YES

Screenshots

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/913

pirate-bot · 2025-08-14T13:07:32Z

Plugin build for 8b553ae is ready 🛎️!

Download build

Note

You can preview the changes in the Playground

Copilot

Pull Request Overview

This PR adds a new "Schedules" tab to the Feedzy RSS Feeds settings page, allowing users to create and manage custom cron schedules. The feature provides a UI for adding schedules with interval (in seconds), display name, and internal name, along with the ability to delete existing schedules.

Key Changes:

Added a new "Schedules" tab with form inputs for creating custom cron schedules
Implemented JavaScript functionality for adding/removing schedules dynamically
Added backend processing to save custom schedules and integrate them with WordPress cron system

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
includes/layouts/settings.php	Added the schedules tab UI with form inputs and table display
js/feedzy-setting.js	Added JavaScript handlers for adding and deleting custom schedules
includes/admin/feedzy-rss-feeds-admin.php	Added backend processing for saving schedules and WordPress cron integration
includes/feedzy-rss-feeds.php	Registered the custom cron schedules filter hook
css/settings.css	Added styling for the schedules table and form elements

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-14T13:08:07Z

+	public function append_custom_cron_schedules( $schedules ) {
+
+		$saved_settings = apply_filters( 'feedzy_get_settings', array() );
+		if ( ! empty( $saved_settings['custom_schedules'] ) || ! is_array( $saved_settings['custom_schedules'] ) ) {


The logical operator should be && instead of ||. Currently, the condition will always be true because ! empty($saved_settings['custom_schedules']) and ! is_array($saved_settings['custom_schedules']) cannot both be false simultaneously. This means the code will execute even when custom_schedules is empty or not an array.

Suggested change

if ( ! empty( $saved_settings['custom_schedules'] ) || ! is_array( $saved_settings['custom_schedules'] ) ) {

if ( ! empty( $saved_settings['custom_schedules'] ) && is_array( $saved_settings['custom_schedules'] ) ) {

Copilot · 2025-08-14T13:08:08Z

+		const display = $('#fz-schedule-display').val();
+		const name = $('#fz-schedule-name').val();
+
+		if (!interval || !display || !name) {


The validation only checks for truthy values but doesn't validate that the interval is a positive number or that the name doesn't contain special characters that could cause issues with HTML attributes or form names.

Suggested change

if (!interval || !display || !name) {

// Validate interval is a positive number

const intervalNum = Number(interval);

const nameIsValid = /^[A-Za-z0-9_]+$/.test(name);

if (

!interval ||

!display ||

!name ||

isNaN(intervalNum) ||

intervalNum <= 0 ||

!nameIsValid

) {

// Optionally, show a user-friendly error message here

Copilot · 2025-08-14T13:08:08Z

+					</button>
+				</td>
+				<input type="hidden" value="${interval}" name="fz-custom-schedule-interval[${name}][interval]">
+				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">


The name variable is inserted directly into HTML without escaping, which could lead to XSS vulnerabilities if the name contains malicious content. The values should be escaped before being inserted into the HTML.

Suggested change

<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">

<tr data-schedule="${escapeHtml(name)}">

<td class="fz-schedule-attributes">

<strong>${escapeHtml(name)}</strong>

</td>

<td class="fz-schedule-attributes">

${escapeHtml(interval)}

</td>

<td class="fz-schedule-attributes">

${escapeHtml(display)}

</td>

<td class="fz-schedule-attributes">

<button type="button" class="btn btn-outline-primary fz-delete-schedule fz-is-destructive" data-schedule="${escapeHtml(name)}">

Delete

</button>

</td>

<input type="hidden" value="${escapeHtml(interval)}" name="fz-custom-schedule-interval[${escapeHtml(name)}][interval]">

<input type="hidden" value="${escapeHtml(display)}" name="fz-custom-schedule-interval[${escapeHtml(name)}][display]">

Copilot · 2025-08-14T13:08:08Z

+					</button>
+				</td>
+				<input type="hidden" value="${interval}" name="fz-custom-schedule-interval[${name}][interval]">
+				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">


The name variable is inserted directly into the data-schedule attribute without escaping, which could lead to attribute injection vulnerabilities.

Suggested change

<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">

<button type="button" class="btn btn-outline-primary fz-delete-schedule fz-is-destructive" data-schedule="${escapedName}">

Delete

</button>

</td>

<input type="hidden" value="${interval}" name="fz-custom-schedule-interval[${escapedName}][interval]">

<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${escapedName}][display]">

Copilot · 2025-08-14T13:08:08Z

+	font-size: 13px;
+}
+
+ .fz-schedules-table {


There's an extra space before the CSS selector .fz-schedules-table which should be removed for consistency.

Suggested change

.fz-schedules-table {

.fz-schedules-table {

pirate-bot · 2025-08-20T15:23:58Z

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

RaduCristianPopescu requested review from Soare-Robert-Daniel and Copilot August 14, 2025 13:06

RaduCristianPopescu self-assigned this Aug 14, 2025

RaduCristianPopescu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 14, 2025

pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 14, 2025

Copilot AI reviewed Aug 14, 2025

View reviewed changes

Soare-Robert-Daniel approved these changes Aug 14, 2025

View reviewed changes

Soare-Robert-Daniel changed the title ~~feat: added a new tab for schedules~~ feat: add custom cron schedules workflow Aug 14, 2025

ineagu added the doc-needed This issue requires documentation updates or additions once it has been completed. label Aug 15, 2025

RaduCristianPopescu and others added 5 commits August 18, 2025 13:16

feat: added a new tab for schedules

d639676

fix: issues

e8dcbe2

fix: lint

896ee9e

chore: re-structure and PRO locks

2ccef50

chore: pro display

8b553ae

Soare-Robert-Daniel force-pushed the feat/schedule_tab branch from 040a2b0 to 8b553ae Compare August 18, 2025 10:19

Soare-Robert-Daniel merged commit 38d0231 into development Aug 18, 2025
9 checks passed

Soare-Robert-Daniel deleted the feat/schedule_tab branch August 18, 2025 10:26

pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add custom cron schedules workflow#1144

feat: add custom cron schedules workflow#1144
Soare-Robert-Daniel merged 5 commits into
developmentfrom
feat/schedule_tab

RaduCristianPopescu commented Aug 14, 2025 •

edited by Soare-Robert-Daniel

Loading

Uh oh!

pirate-bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Uh oh!

pirate-bot commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	if ( ! empty( $saved_settings['custom_schedules'] ) \|\| ! is_array( $saved_settings['custom_schedules'] ) ) {
	if ( ! empty( $saved_settings['custom_schedules'] ) && is_array( $saved_settings['custom_schedules'] ) ) {

-		if (!interval || !display || !name) {
+		// Validate interval is a positive number
+		const intervalNum = Number(interval);
+		const nameIsValid = /^[A-Za-z0-9_]+$/.test(name);
+		if (
+			!interval ||
+			!display ||
+			!name ||
+			isNaN(intervalNum) ||
+			intervalNum <= 0 ||
+			!nameIsValid
+		) {
+			// Optionally, show a user-friendly error message here

-				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">
+			<tr data-schedule="${escapeHtml(name)}">
+				<td class="fz-schedule-attributes">
+					<strong>${escapeHtml(name)}</strong>
+				</td>
+				<td class="fz-schedule-attributes">
+					${escapeHtml(interval)}
+				</td>
+				<td class="fz-schedule-attributes">
+					${escapeHtml(display)}
+				</td>
+				<td class="fz-schedule-attributes">
+					<button type="button" class="btn btn-outline-primary fz-delete-schedule fz-is-destructive" data-schedule="${escapeHtml(name)}">
+						Delete
+					</button>
+				</td>
+				<input type="hidden" value="${escapeHtml(interval)}" name="fz-custom-schedule-interval[${escapeHtml(name)}][interval]">
+				<input type="hidden" value="${escapeHtml(display)}" name="fz-custom-schedule-interval[${escapeHtml(name)}][display]">

-				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">
+					<button type="button" class="btn btn-outline-primary fz-delete-schedule fz-is-destructive" data-schedule="${escapedName}">
+						Delete
+					</button>
+				</td>
+				<input type="hidden" value="${interval}" name="fz-custom-schedule-interval[${escapedName}][interval]">
+				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${escapedName}][display]">

Conversation

RaduCristianPopescu commented Aug 14, 2025 • edited by Soare-Robert-Daniel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Will affect visual aspect of the product

Screenshots

Uh oh!

pirate-bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pirate-bot commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RaduCristianPopescu commented Aug 14, 2025 •

edited by Soare-Robert-Daniel

Loading

pirate-bot commented Aug 14, 2025 •

edited

Loading