Skip to content

Added referral url and change layout option#1147

Merged
Soare-Robert-Daniel merged 8 commits into
developmentfrom
feat/pro/911
Aug 19, 2025
Merged

Added referral url and change layout option#1147
Soare-Robert-Daniel merged 8 commits into
developmentfrom
feat/pro/911

Conversation

@girishpanchal30
Copy link
Copy Markdown
Contributor

Summary

Added referral URL and layout change option, and moved cache time and sorting order option inside advanced panel.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/911

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 18, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 18, 2025
@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Aug 18, 2025

Plugin build for e32bbf2 is ready 🛎️!

Note

You can preview the changes in the Playground

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@ineagu, with this PR, we have 2 methods to replace the layout.

Should we keep both or just one of them? And which?

Method 1. Via Replace, which pops up a modal with a rendered layout

CleanShot 2025-08-18 at 18 01 20@2x CleanShot 2025-08-18 at 17 48 58@2x

Method 2. Sidebar Selector (added in this PR)

CleanShot 2025-08-18 at 17 48 46@2x

@ineagu
Copy link
Copy Markdown
Contributor

ineagu commented Aug 18, 2025

we should use method 2, presented here but week the layout picked on 1 line with smaller icons, aligned horizontal instead vertical.

Also the layout won't get a separate tab, but be present in settings, which would be the first one, referral tab would got before advanced at the end.

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

I have aligned the layout options and moved the referral tab before the advance tab.

image

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

I updated the design to be minimal and less distracting

CleanShot 2025-08-19 at 15 59 59@2x

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@girishpanchal30 this was not necessary bdb55f3, your idea with passing the $attributes along is good (I also updated my other PR based on this)

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

@Soare-Robert-Daniel Okay, I will revert the changes of bdb55f3

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

Soare-Robert-Daniel commented Aug 19, 2025

@girishpanchal30 no need it, I found a better one, we already had a built-in mechanism for referral_url

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

I will merge this. Seems to work fine. Any issue will be solved in the Release PR.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 5949f49 into development Aug 19, 2025
9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the feat/pro/911 branch August 19, 2025 13:42
@pirate-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants