Addressing PR comments

[Claude]

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Change default shortcode max items from 5 to 10</issue_title>
<issue_description>## Problem

The shortcode default for max is 5, but the free tier cap is 10 items. This means free users who don't explicitly set max see only 5 items — half of what they're entitled to. Multiple uninstall survey responses cite "limited" display as a frustration point. The mismatch between the default (5) and the actual cap (10) creates a false perception that the plugin is more restrictive than it actually is.

Solution

admin-abstract.php — Change 'max' => '5' to 'max' => '10' in get_short_code_attributes().

This is a "smart defaults > configurability" change: users get the full value of the free tier without needing to discover and set the max parameter.

Files Affected

• includes/abstract/feedzy-rss-feeds-admin-abstract.php

Acceptance Criteria

• New shortcodes without explicit max show 10 items by default
• Existing shortcodes with explicit max="5" are unaffected
• Free tier cap (10) still enforced — no items beyond 10
• Pro users can still set any value they want

Priority: Low — smart default, reduces perceived limitation in free tier
Regression risk: Low — only affects shortcodes without explicit max</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

• Fixes Change default shortcode max items from 5 to 10 #1203

[Copilot]

Pull request overview

Updates Feedzy’s default “max items” setting to match the free-tier entitlement (10 items), reducing confusion when users don’t explicitly pass max in shortcodes/blocks.

Changes:

• Changed shortcode default max from 5 to 10 in get_short_code_attributes().
• Updated sanitization fallback for invalid/empty max values from 5 to 10.
• Aligned Gutenberg block attribute default and UI placeholder example to 10.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
includes/abstract/feedzy-rss-feeds-admin-abstract.php	Updates shortcode default and sanitization fallback for max to 10.
includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php	Updates Gutenberg block max default to 10.
includes/admin/feedzy-rss-feeds-ui-lang.php	Updates UI placeholder example for max to 10.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

max is registered with 'type' => 'number' but its default is set as a string ('10'). Using a numeric literal for the default keeps the attribute schema consistent and avoids subtle type/coercion differences during block parsing/serialization.

[ineagu]

@claude[agent] can you fix the review items?

[Claude]

@claude[agent] can you fix the review items?

Fixed in 535919b - changed the Gutenberg block max default from string '10' to numeric 10 to match the 'type' => 'number' declaration.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php:111

• offset is declared as a Gutenberg attribute with type: 'number', but its PHP schema sets default to the string '0'. This violates the block attribute type contract and can lead to block validation warnings. Use a numeric literal (0) for the default to match the declared type (and align with the editor-side schema).

					'offset'          => array(
						'type'    => 'number',
						'default' => '0',
					),

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The Gutenberg block’s JS attribute schema still defaults max to 5 (see js/FeedzyBlock/attributes.js), while the PHP register_block_type() schema now defaults to 10. This mismatch can cause newly inserted blocks in the editor to still start at 5 items and may also trigger block validation/serialization inconsistencies. Update the editor-side attributes default (and rebuilt assets, if applicable) to keep the JS and PHP schemas in sync.

Suggested change

	'default' => 10,
	'default' => 5,

[Copilot]

This PR changes the shortcode default/fallback for max to 10, but there’s no unit test asserting the default behavior when max is omitted/empty/invalid. Since the repo already has PHPUnit coverage for the admin abstract, add a test that get_short_code_attributes([]) defaults max to 10 and that sanitize_attr() falls back to 10 for empty/non-numeric values (while preserving explicit numeric values like 5).