Skip to content

Fix fatal sprintf argument mismatch in feedzy-rss-feeds-ui-lang.php#1215

Merged
vytisbulkevicius merged 2 commits intodevelopmentfrom
copilot/fix-argument-error-feedzy-plugin
Apr 24, 2026
Merged

Fix fatal sprintf argument mismatch in feedzy-rss-feeds-ui-lang.php#1215
vytisbulkevicius merged 2 commits intodevelopmentfrom
copilot/fix-argument-error-feedzy-plugin

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 24, 2026

PHP 8 throws a fatal error when sprintf receives fewer arguments than placeholders in the format string. The get_form_elements() meta description string declared 6 unique positional placeholders (%1$s%6$s) but only 4 arguments were passed, crashing the widget on the Customizer screen.

Change

  • includes/admin/feedzy-rss-feeds-ui-lang.php — Replaced %3$sdate%4$s and %5$stime%6$s with %1$sdate%2$s and %1$stime%2$s, reusing the existing <code>/</code> positional args instead of requiring new ones. This matches the pattern already used in the adjacent Pro/categories variant of the same string.
// Before (6 unique placeholders, only 4 args supplied → fatal)
__( '...%1$sauthor%2$s, %3$sdate%4$s and %5$stime%6$s?...View documentation %3$shere%4$s.' )

// After (4 unique placeholders, 4 args supplied → correct)
__( '...%1$sauthor%2$s, %1$sdate%2$s and %1$stime%2$s?...View documentation %3$shere%4$s.' )

…s-ui-lang.php

Agent-Logs-Url: https://github.com/Codeinwp/feedzy-rss-feeds/sessions/c513702e-da37-4e3f-9ba1-56d28923066e

Co-authored-by: rodica-andronache <3266155+rodica-andronache@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix fatal error caused by missing arguments in Feedzy plugin Fix fatal sprintf argument mismatch in feedzy-rss-feeds-ui-lang.php Apr 24, 2026
Copilot AI requested a review from rodica-andronache April 24, 2026 05:54
@rodica-andronache rodica-andronache marked this pull request as ready for review April 24, 2026 05:55
@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Apr 24, 2026

🌍 i18n String Review Report

📊 Summary

Category Count
➕ Added 1
➖ Removed 1
🔄 Changed 0
Total 2
➕ Added Strings (1) - Click to expand
String Location Words Suggested Match
Should we display additional meta fields out of... includes/admin/feedzy-rss... 21 Should we display additional meta fields out of %1$sauthor%2$s, %3$sdate%4$s and %5$stime%6$s? (comma-separated list, in order of display). View documentation %3$shere%4$s.
Total 21
➖ Removed Strings (1) - Click to expand
String Location
Should we display additional meta fields out of... includes/admin/feedzy-rss...

@pirate-bot
Copy link
Copy Markdown
Contributor

Plugin build for 1c38a64 is ready 🛎️!

Note

You can preview the changes in the Playground

@vytisbulkevicius vytisbulkevicius merged commit 5bf2676 into development Apr 24, 2026
16 of 23 checks passed
@vytisbulkevicius vytisbulkevicius deleted the copilot/fix-argument-error-feedzy-plugin branch April 24, 2026 06:13
@pirate-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.1.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error: Uncaught Error: 7 arguments are required, 5 given in feedzy-rss-feeds-ui-lang.php on line 92

4 participants