refactor: update lazyload logic to conditionally load profiler based on user state and settings

Author: selul

inc/manager.php

@@ -420,7 +420,8 @@ public function replace_content( $html, $partial = false ) {
 		if ( defined( 'REST_REQUEST' ) && REST_REQUEST && is_user_logged_in() && ( apply_filters( 'optml_force_replacement', false ) !== true ) ) {
 			return $html;
 		}
-		if ( $this->settings->is_lazyload_type_viewport() && ! $partial ) {
+		$should_load_profiler = ! $partial && apply_filters( 'optml_page_profiler_disable', false ) === false;
+		if ( $should_load_profiler ) {
 			$profile_id = Profile::generate_id( $html );
 			// We disable the optimizer for logged in users.
 			if ( ! is_user_logged_in() || ! apply_filters( 'optml_force_page_profiler', false ) !== true ) {
@@ -497,7 +498,7 @@ public function replace_content( $html, $partial = false ) {
 		$html = $this->process_urls_from_content( $html );
 
 		$html = apply_filters( 'optml_url_post_process', $html );
-		if ( $this->settings->is_lazyload_type_viewport() && ! $partial ) {
+		if ( $should_load_profiler ) {
 			Profile::reset_current_profile();
 		}
 		return $html;

tests/test-lazyload.php

@@ -407,7 +407,7 @@ public function test_should_not_add_loading () {
 		$replaced_content = Optml_Manager::instance()->replace_content( $content );
 		$this->assertStringContainsString( 'i.optimole.com', $replaced_content );
 		$this->assertStringContainsString( 'data-opt-src', $replaced_content );
-		$this->assertEquals( 2, substr_count( $replaced_content, 'loading="lazy"' ) );
+		$this->assertEquals( 0, substr_count( $replaced_content, 'loading="lazy"' ) );
 		$this->assertStringContainsString( 'loading="eager"', $replaced_content );
 	}