Skip to content

Commit d42a41b

Browse files
committed
preload only lcp urls and fetch priority only on lcp
1 parent a207794 commit d42a41b

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

inc/tag_replacer.php

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -433,21 +433,15 @@ public function regular_tag_replace( $new_tag, $original_url, $new_url, $optml_a
433433

434434
if ( $this->settings->is_lazyload_type_viewport() ) {
435435
$image_id = $this->get_id_by_url( $original_url );
436-
$is_in_all_viewports = Optml_Manager::instance()->page_profiler->is_in_all_viewports( $image_id );
437436
$is_lcp_image = Optml_Manager::instance()->page_profiler->is_lcp_image_in_all_viewports( $image_id );
438437
$no_viewport_data_available = ! Optml_Manager::instance()->page_profiler->check_data_availability();
439438

440439
if ( OPTML_DEBUG ) {
441-
if ( $is_in_all_viewports ) {
442-
do_action( 'optml_log', 'Adding preload priority for image ' . $original_url . '|' . $image_id );
443-
} elseif ( $is_lcp_image ) {
444-
do_action( 'optml_log', 'Adding preload image is LCP ' . $original_url . '|' . $image_id );
445-
}
440+
do_action( 'optml_log', 'Adding fetchpriority image is LCP ' . $original_url . '|' . $image_id );
446441
}
447442

448-
if ( $is_in_all_viewports || $is_lcp_image ) {
443+
if ( $is_lcp_image ) {
449444
$new_tag = preg_replace( '/<img/im', $is_slashed ? '<img fetchpriority=\"high\"' : '<img fetchpriority="high"', $new_tag );
450-
Links::add_id( $image_id, 'high' ); // collect ID for preload.
451445
}
452446
}
453447

inc/v2/BgOptimizer/Lazyload.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public static function get_personalized_css( $data ) {
4141
do_action( 'optml_log', 'LCP data: ' . $device . ' ' . print_r( $lcp_data, true ) );
4242
}
4343
$css_selectors[ $device ] = [];
44-
$preload_urls[ $device ] = [];
4544
foreach ( $personalized_selectors as $selector => $above_fold_selectors ) {
4645
if ( ! isset( $lazyload_selectors[ $selector ] ) ) {
4746
continue;
@@ -51,12 +50,12 @@ public static function get_personalized_css( $data ) {
5150
} else {
5251
foreach ( $above_fold_selectors as $above_fold_selector => $bg_urls ) {
5352
$css_selectors[ $device ][] = 'html ' . strip_tags( $selector ) . ':not(' . strip_tags( $above_fold_selector ) . '):not(.optml-bg-lazyloaded)';
54-
$preload_urls[ $device ] = array_merge( $preload_urls[ $device ], $bg_urls );
5553
}
5654
}
5755
}
56+
57+
$preload_urls[ $device ] = [];
5858
$css_selectors[ $device ] = array_unique( $css_selectors[ $device ] );
59-
$preload_urls[ $device ] = array_unique( $preload_urls[ $device ] );
6059
if ( isset( $lcp_data['type'] ) && $lcp_data['type'] === 'bg' ) {
6160
if ( ! empty( $lcp_data['bgSelector'] ) ) {
6261
$css_selectors[ $device ] = array_map(

0 commit comments

Comments
 (0)