Skip to content

Commit d701694

Browse files
authored
Merge pull request #1044 from Codeinwp/bugfix/1687
Prevent cross site scripting
2 parents 9f40955 + c5045e2 commit d701694

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

inc/tag_replacer.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,11 @@ public function add_missing_srcset_attributes( $tag, $missing_srcsets, $new_url,
504504
$optimized_url = $this->change_url_for_size( $new_url, $width, $height, $dpr );
505505

506506
if ( $optimized_url ) {
507-
$new_srcset_entries[] = $optimized_url . ' ' . $descriptor;
507+
$escaped_url = esc_url( $optimized_url );
508+
if ( empty( $escaped_url ) ) {
509+
continue;
510+
}
511+
$new_srcset_entries[] = $escaped_url . ' ' . esc_attr( $descriptor );
508512

509513
// Add sizes attribute entry for responsive breakpoints
510514
if ( $breakpoint > 0 ) {

0 commit comments

Comments
 (0)