fix: type verification for filter values#1003
Merged
Merged
Conversation
Re-add the extra type verification for values that are computed with filters.
Collaborator
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-adds defensive type verification for filter values to prevent warnings when custom WordPress filters return unexpected types. The changes ensure that functions hooked to WordPress filters properly handle non-array return values from other filters.
- Added type guards to check if parameters are arrays before processing them
- Updated PHPDoc annotations to reflect that parameters can be mixed types
- Removed resolved PHPStan baseline entries for improved type specificity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| inc/tag_replacer.php | Added array type check for $sources parameter in filter_srcset_attr method to handle non-array values from wp_calculate_image_srcset filter |
| inc/app_replacer.php | Added array type check for $resize parameter in get_optimized_image_url method to prevent errors when accessing array keys |
| inc/admin.php | Added array type check for $links parameter in add_action_links method to handle non-array values from plugin action links filter |
| phpstan-baseline.neon | Removed baseline entries for methods that now have proper type annotations with mixed types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abaicus
approved these changes
Nov 24, 2025
Collaborator
|
🎉 This PR is included in version 4.1.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add the extra type verification for values that are computed with filters.
All Submissions:
Changes proposed in this Pull Request:
Re-add some type verifications from 407e4fe
Closes #1002
How to test the changes in this Pull Request:
Other information: