Retry restore of offloaded images that previously failed rollback

[Copilot]

Failed rollbacks tag attachments with optimole_rollback_error, and the rollback selection query excludes tagged attachments. Because the clear-errors path only removed optimole_offload_error, retrying a restore silently skipped the images that had failed — potentially leaving them permanently unavailable locally. The offload flow already clears its error flags before retrying; the rollback flow did not.

Changes

• inc/media_offload.php — Parametrized clear_offload_errors_meta() with an optional meta key (defaults to the offload-error key) and added clear_rollback_errors_meta() to delete optimole_rollback_error.
• inc/rest.php — clear_offload_errors() clears rollback errors when the request action is rollback_images, offload errors otherwise.
• assets/src/dashboard/utils/api.js — clearOffloadErrors() takes an action (default offload_images) forwarded as a query arg.
• assets/src/dashboard/parts/connected/settings/OffloadMedia.js — onRollbackdMedia() awaits clearOffloadErrors('rollback_images') before syncing, mirroring the offload path.
• inc/cli/cli_media.php — WP-CLI rollback clears rollback errors too, since it shares the rollback query.
• tests/test-media.php — Added coverage: an offloaded attachment with optimole_rollback_error is excluded from rollback selection, then eligible again after clear_rollback_errors_meta().

Rollback flow, before → after

checkOffloadConflicts( async response => {
	if ( 0 === response.data.length ) {
		await clearOffloadErrors( 'rollback_images' ); // added: re-eligible failed items
		// ...saveSettings + callSync({ action: 'rollback_images' })
	}
});

Note: the dashboard JS change requires rebuilding assets/build/ (npm run build:dashboard); build artifacts are intentionally excluded from this diff.

[selul]

fix this error @copilot

[Copilot]

Fixed in 6c9b1c5. The baseline entries were stale — both clear_offload_errors_meta() and clear_rollback_errors_meta() have @return int|bool PHPDoc, which satisfies PHPStan's missingType.return rule, so the ignore entries no longer matched. Removed both.

[Copilot]

Correction: the fix is in commit e837999.

[pirate-bot]

Plugin build for 5806d24 is ready 🛎️!

• Download build
• Download dev