Skip to content

fix: disabling scaling also removes retina functionality#954

Closed
RaduCristianPopescu wants to merge 2 commits into
developmentfrom
fix/image_scalling
Closed

fix: disabling scaling also removes retina functionality#954
RaduCristianPopescu wants to merge 2 commits into
developmentfrom
fix/image_scalling

Conversation

@RaduCristianPopescu

Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

When Image Scaling is disabled, the Retina Quality toggle is automatically disabled with an informational message explaining the dependency.
CleanShot 2025-09-01 at 17 46 05@2x

Closes #769

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot

pirate-bot commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

Plugin build for 9f9ab98 is ready 🛎️!

@selul

selul commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

@RaduCristianPopescu here I think is no longer relevant, in the most recent version we also introduced retina based srcset which is non js dependent

public function filter_attachment_image_attributes( $attr, $attachment, $size ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants