fix: disabling scaling also removes retina functionality#954
Closed
RaduCristianPopescu wants to merge 2 commits into
Closed
fix: disabling scaling also removes retina functionality#954RaduCristianPopescu wants to merge 2 commits into
RaduCristianPopescu wants to merge 2 commits into
Conversation
Collaborator
Contributor
|
@RaduCristianPopescu here I think is no longer relevant, in the most recent version we also introduced retina based srcset which is non js dependent optimole-wp/inc/tag_replacer.php Line 125 in e40ce70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
When Image Scaling is disabled, the Retina Quality toggle is automatically disabled with an informational message explaining the dependency.

Closes #769
Other information: