Skip to content

Improve quality setting handling in Compression settings#976

Closed
ineagu wants to merge 2 commits into
Codeinwp:developmentfrom
ineagu:fix-defaultqvalue
Closed

Improve quality setting handling in Compression settings#976
ineagu wants to merge 2 commits into
Codeinwp:developmentfrom
ineagu:fix-defaultqvalue

Conversation

@ineagu

@ineagu ineagu commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Refactored the Compression.js component to better handle toggling between auto and manual quality settings while fixing https://github.com/Codeinwp/optimole-service/issues/1516#issuecomment-3355204589. Updated the minimum allowed quality value in settings.php from 1 to 50 to stay consistent with the front-end.

Changed default compression setting to 80, which is more likely to be used vs 90, which is not recommended.

All Submissions:

Changes proposed in this Pull Request:

Refactored the Compression.js component to better handle toggling between auto and manual quality settings while fixing https://github.com/Codeinwp/optimole-service/issues/1516#issuecomment-3355204589. Updated the minimum allowed quality value in settings.php from 1 to 50 to stay consistent with the front-end.

Changed default compression setting to 80, which is more likely to be used vs 90, which is not recommended.

Closes # .

How to test the changes in this Pull Request:

  1. Disable machine learning compression & save
  2. Ensure the default value is used on the frontend.
  3. Make sure going back to mauto or migrating from an older version works as expected.

Other information:

  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • [ x] Have you successfully ran tests with your changes locally?

Refactored the Compression.js component to better handle toggling between auto and manual quality settings, preserving the user's manual quality value when switching modes. Updated the minimum allowed quality value in settings.php from 1 to 50 for better image quality control.
@ineagu ineagu requested a review from selul October 1, 2025 11:55
@selul selul removed their request for review October 1, 2025 12:00
@ineagu ineagu closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant