Enhanced dynamic content handling for archive titles#2879
Closed
girishpanchal30 wants to merge 2 commits into
Closed
Enhanced dynamic content handling for archive titles#2879girishpanchal30 wants to merge 2 commits into
girishpanchal30 wants to merge 2 commits into
Conversation
Contributor
Bundle Size Diff
|
There was a problem hiding this comment.
Pull request overview
This PR enhances the Dynamic Value “archive title” handling by adding UI controls to optionally override (or remove) the default WordPress archive title prefix and wiring the new attributes through the editor preview + PHP rendering.
Changes:
- Added an “Override Archive Title Prefix” toggle and optional prefix text input for
archiveTitledynamic content. - Extended the dynamic value format + editor preview attribute handling to include the new archive title settings.
- Updated the PHP dynamic-content parser and introduced server-side logic to apply the prefix override via
get_the_archive_title_prefix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/blocks/plugins/dynamic-content/value/index.js | Adds new archive-title-related attributes to the dynamic value format and editor-side preview requests. |
| src/blocks/plugins/dynamic-content/value/fields.js | Adds settings UI (toggle + input) for archive title prefix override. |
| inc/plugins/class-dynamic-content.php | Parses new data-archive-title-* attributes and applies an optional archive title prefix override when resolving dynamic content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Plugin build for 033289a is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":460.4,"q50":468,"q75":500,"cnt":10}, firstPaint: {"q25":512.7,"q50":588.15,"q75":692.4,"cnt":10}, domContentLoaded: {"q25":3478.6,"q50":3512.95,"q75":3554,"cnt":10}, loaded: {"q25":3480.8,"q50":3514.85,"q75":3556.4,"cnt":10}, firstContentfulPaint: {"q25":4027.9,"q50":4053.35,"q75":4119,"cnt":10}, firstBlock: {"q25":13674.9,"q50":13730.15,"q75":13920.4,"cnt":10}, type: {"q25":22.15,"q50":23.76,"q75":27.49,"cnt":10}, typeWithoutInspector: {"q25":20.13,"q50":21.32,"q75":21.91,"cnt":10}, typeWithTopToolbar: {"q25":26.81,"q50":27.73,"q75":28.5,"cnt":10}, typeContainer: {"q25":12.44,"q50":12.98,"q75":13.4,"cnt":10}, focus: {"q25":104.8,"q50":106.53,"q75":112.09,"cnt":10}, inserterOpen: {"q25":35.85,"q50":36.52,"q75":37.31,"cnt":10}, inserterSearch: {"q25":12.18,"q50":12.37,"q75":13.14,"cnt":10}, inserterHover: {"q25":4.45,"q50":4.65,"q75":4.71,"cnt":20}, loadPatterns: {"q25":1490.82,"q50":1529.73,"q75":1689.52,"cnt":10}, listViewOpen: {"q25":219.26,"q50":226.47,"q75":232.24,"cnt":10} |
Contributor
Contributor
|
@Soare-Robert-Daniel yes. We don't need additional controls (like the prefix) so we should be ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/266
Summary
Added toggle and input field for the archive title dynamic content.
Screenshots
Test instructions
Checklist before the final review