starter-sites-onboarding-notice#465
Open
harshitarora-in wants to merge 12 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-incomplete
Collaborator
There was a problem hiding this comment.
Pull request overview
Adds a dismissible onboarding promo notice to the Site List step, with localized backend data for visibility, dismissal, license-tier-specific copy, and dashboard redirect URL handling.
Changes:
- Added the promo notice React component and inserted it into the Site List flow.
- Added SCSS styling and imported it into onboarding styles.
- Added AJAX dismissal handling, localization data, tier-aware promo selection, and admin URL fallback data.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
onboarding/src/style.scss |
Imports the new promo notice stylesheet. |
onboarding/src/scss/_onboarding-promo-notice.scss |
Adds layout and responsive styles for the onboarding promo notice. |
onboarding/src/Components/Steps/SiteList.js |
Renders the new promo notice between filters and sites. |
onboarding/src/Components/OnboardingPromoNotice.js |
Implements promo display, tier-specific message, mailto CTA, and dismissal action. |
onboarding/src/Components/Header.js |
Updates exit redirect to use localized admin URL fallback. |
includes/Admin.php |
Adds dismissal option/action, promo localization data, tier decision logic, and admin URL localization. |
Comments suppressed due to low confidence (1)
onboarding/src/Components/OnboardingPromoNotice.js:23
- The mailto subject is user-facing text but is not wrapped in the WordPress i18n helpers used for the visible notice strings. This leaves the generated email subject untranslated for localized users.
const requestSiteLink =
'mailto:contact@themeisle.com?subject=' +
encodeURIComponent( 'Starter Site Request' ) +
'&body=' +
encodeURIComponent( emailBody );
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+53
to
+59
| const dismissNotice = () => { | ||
| setIsVisible( false ); | ||
| ajaxAction( | ||
| tiobDash.onboardingPromoNotice.ajaxURL, | ||
| 'dismiss_onboarding_promo_notice', | ||
| tiobDash.onboardingPromoNotice.nonce | ||
| ).catch( () => null ); |
Soare-Robert-Daniel
requested changes
May 14, 2026
Contributor
Author
|
@claude[agent] review the comment in this thread and apply the suggested changes. |
…nd cleanup unused code Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/c636c138-2459-452b-a54e-7ec23c3cfe96 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/1a67f28d-97f3-4be1-81ef-6fe9ff05ad79 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/1a67f28d-97f3-4be1-81ef-6fe9ff05ad79 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
includes/Admin.php:228
- This only normalizes Neve plan categories
1,2, and3, butLicense::NEVE_CATEGORY_MAPPINGdefines valid categories through9and existing Neve plan handling accepts any mapped category. Business/Agency Neve categories such as4,5,6,8, or9skip this branch, so the promo variant can be decided from unrelated TPC tier data instead of the active Neve plan.
if ( in_array( $neve_plan, array( 1, 2, 3 ), true ) ) {
// Normalize Neve plan category to TPC tier using License::NEVE_CATEGORY_MAPPING
$normalized_neve_tier = isset( License::NEVE_CATEGORY_MAPPING[ $neve_plan ] ) ? License::NEVE_CATEGORY_MAPPING[ $neve_plan ] : -1;
return in_array( $normalized_neve_tier, array( 2, 3 ), true );
| $license_key = isset( $license_data->key ) ? strtolower( trim( (string) $license_data->key ) ) : ''; | ||
| $license_tier = License::get_license_tier( 0 ); | ||
| $raw_tier = isset( $license_data->tier ) ? absint( $license_data->tier ) : 0; | ||
| $neve_plan = absint( apply_filters( 'product_neve_license_plan', -1 ) ); |
| * | ||
| * @return bool | ||
| */ | ||
| private function should_show_business_agency_promo_text() { |
Comment on lines
+54
to
+60
| const dismissNotice = () => { | ||
| setIsVisible( false ); | ||
| ajaxAction( | ||
| tiobDash.onboardingPromoNotice.ajaxURL, | ||
| 'dismiss_onboarding_promo_notice', | ||
| tiobDash.onboardingPromoNotice.nonce | ||
| ).catch( () => null ); |
| return; | ||
| } | ||
|
|
||
| if ( ! wp_verify_nonce( $_REQUEST['nonce'], 'dismiss_onboarding_promo_notice' ) ) { |
| unset( $response['code'] ); | ||
| unset( $response['message'] ); | ||
|
|
||
| update_option( self::ONBOARDING_PROMO_NOTICE_DISMISSED, 'yes' ); |
Contributor
Author
|
@claude[agent] Review the comments in this thread and apply the fixes. |
- Add proper nonce sanitization with wp_unslash and sanitize_text_field - Add capability check (install_plugins) before allowing dismissal - Fix Neve plan default -1 handling by removing absint() to allow fallback to TPC license tier Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/69fed254-eb0a-4138-aca4-b87abd12189f Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Applied all fixes from the review thread in commit 5776780:
|
Comment on lines
+232
to
+236
| // Check Neve plan only if it's a valid category (not -1 default) | ||
| if ( -1 !== $neve_plan && in_array( $neve_plan, array( 1, 2, 3, 4, 5, 6, 7, 8, 9 ), true ) ) { | ||
| // Normalize Neve plan category to TPC tier using License::NEVE_CATEGORY_MAPPING | ||
| $normalized_neve_tier = isset( License::NEVE_CATEGORY_MAPPING[ $neve_plan ] ) ? License::NEVE_CATEGORY_MAPPING[ $neve_plan ] : -1; | ||
| return in_array( $normalized_neve_tier, array( 2, 3 ), true ); |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Applied in eeac6df. The promo tier check now reuses neve_license_plan(), and I added PHPUnit + onboarding E2E coverage for the tier selection and dismiss flow. Screenshot (UI unchanged): https://github.com/user-attachments/assets/83986407-7f72-4012-a012-8585d843c141
Comment on lines
+217
to
+223
| private function should_show_business_agency_promo_text() { | ||
| $license_data = License::get_license_data(); | ||
| $license_key = isset( $license_data->key ) ? strtolower( trim( (string) $license_data->key ) ) : ''; | ||
| $license_tier = License::get_license_tier( 0 ); | ||
| $raw_tier = isset( $license_data->tier ) ? absint( $license_data->tier ) : 0; | ||
| $neve_plan = apply_filters( 'product_neve_license_plan', -1 ); | ||
|
|
| <EditorSelector /> | ||
| </div> | ||
| <Filters /> | ||
| <OnboardingPromoNotice /> |
Contributor
|
the goal looks good for me, the code/implementation need validaiton |
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/32d60726-d310-4c01-a838-ee64ba6531f9 Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
Validation updates are in eeac6df. I added targeted PHPUnit coverage for the promo tier logic, added onboarding E2E coverage for notice dismissal persistence, and ran local syntax/build/lint checks where the sandbox allowed it. Screenshot (UI unchanged): https://github.com/user-attachments/assets/83986407-7f72-4012-a012-8585d843c141 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
Author
|
Hi @Soare-Robert-Daniel, I’ve fixed the changes using Copilot. Could you please review them and validate the fixes? I’ve tested everything, and it works as expected. Thanks! |
Soare-Robert-Daniel
approved these changes
May 20, 2026
ineagu
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dismiss_onboarding_promo_notice) and stored in plugin options.request a sitemailto CTA./wp-admin.Will affect visual aspect of the product
YES
Screenshots
Free/personal plan usersBusiness/agency UsersTest instructions
request a sitemailto link.Check before Pull Request is ready:
Closes #.