feat(onboarding): show 4 starter sites per row on laptop and up#478
Merged
Conversation
Widen the onboarding starter-sites grid from 3 to 4 columns at the laptop breakpoint (>=992px) so users see ~8 templates at once instead of leaving large empty margins on wider screens. Tablet stays at 2 columns, mobile at 1. Keep the JS in sync with the new column count: - Page size 9 -> 12 (initial useState, the reset effect, and the lazy-load increment) so each render fills whole rows. 12 divides evenly by both 3 and 4, so rows stay full at every breakpoint. - Search "Browse more" divider padding % 3 -> % 4 so the divider lands on a clean row boundary under the 4-column grid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QrGf4K9upxDKhRPVCztoLs
ineagu
added
enhancement
Member
|
@codex[agent] Fix the failing e2e test by making the selector more specific. |
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
The grid now renders a full page of 12 cards, so card page-shot buttons
(e.g. "Gallery", "Ballet Blog", "All Courses") contain "all" as a substring.
The non-exact getByRole('button', { name: 'All' }) locator then resolved to
multiple elements (Playwright strict mode violation). Match the All/Free
filter buttons by exact name.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYVWBEDjCM3wzBP6Ew1Ku4
Collaborator
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
HardeepAsrani
approved these changes
Jun 22, 2026
HardeepAsrani
approved these changes
Jun 22, 2026
Collaborator
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widen the onboarding starter-sites grid from 3 to 4 columns on laptop and up so users see ~8 templates at once instead of leaving large empty margins on wider screens. Cards get narrower but stay tall enough to read clearly (aspect-ratio
0.84/1).Closes #477
What changed
onboarding/src/scss/_general.scss—ob-general--laptop()now setsgrid-template-columns: repeat(4, minmax(0, 1fr))(was1fr 1fr 1fr).minmax(0, 1fr)prevents grid blowout from long titles. This cascades to the desktop/desktop-large breakpoints (which were empty). Tablet stays at 2 columns, mobile at 1.onboarding/src/Components/Sites.js9 → 12in the initialuseState, the reset effect, and the lazy-load increment — so every render and each scroll-load fills whole rows. 12 divides evenly by both 3 and 4, so rows stay full at every breakpoint.% 3 → % 4(and3 - remainder → 4 - remainder) so the "Not quite right? Browse more" divider lands on a clean row boundary under the 4-column grid.How to test
yarn build(compiles the onboarding bundle —build/is gitignored, so onlysrc/is committed here).Notes
Check before Pull Request is ready: