Skip to content

feat(onboarding): show 4 starter sites per row on laptop and up #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ineagu merged 2 commits into from
Jun 22, 2026
Merged

feat(onboarding): show 4 starter sites per row on laptop and up #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0a429a
feat(onboarding): show 4 starter sites per row on laptop and up
ineagu Jun 22, 2026
1f51577
test(onboarding): match All/Free filter buttons exactly
ineagu Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions e2e-tests/specs/onboarding.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,12 @@ test.describe('Onboarding', () => {
expect(await page.locator('.ss-card .ss-badge').count()).toBeGreaterThan(0);

// 'All' and 'Free' should show after you select a category.
// Match exactly: card page-shot buttons (e.g. "Gallery", "Ballet Blog",
// "All Courses") also contain "all" as a substring, so a non-exact name
// match resolves to multiple elements once the grid renders a full page.
await page.locator('.ob-cat-wrap').first().click();
await expect(page.getByRole('button', { name: 'All' })).toBeVisible();
await expect(page.getByRole('button', { name: 'Free' })).toBeVisible();
await expect(page.getByRole('button', { name: 'All', exact: true })).toBeVisible();
await expect(page.getByRole('button', { name: 'Free', exact: true })).toBeVisible();

// Check card structure.
const firstListedSiteCard = page.locator('.ss-card-wrap').first();
Expand Down
10 changes: 5 additions & 5 deletions onboarding/src/Components/Sites.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ const Sites = ( {
sortBy,
selectedColors,
} ) => {
const [ maxShown, setMaxShown ] = useState( 9 );
const [ maxShown, setMaxShown ] = useState( 12 );
const { sites = {} } = getSites;

useEffect( () => {
setMaxShown( 9 );
setMaxShown( 12 );
}, [ editor, category, searchQuery, sortBy, selectedColors ] );

const getBuilders = () => Object.keys( sites );
Expand Down Expand Up @@ -218,9 +218,9 @@ const Sites = ( {
const rest = filterByColors( filterByCategory( ranked, category ) ).filter(
( site ) => site && site.slug && ! inMatches[ site.slug ]
);
const remainder = matches.length % 3;
const remainder = matches.length % 4;
const pad =
remainder === 0 ? 0 : Math.min( 3 - remainder, rest.length );
remainder === 0 ? 0 : Math.min( 4 - remainder, rest.length );

return {
list: [ ...matches, ...rest ],
Expand Down Expand Up @@ -280,7 +280,7 @@ const Sites = ( {
return false;
}

setMaxShown( ( shown ) => shown + 9 );
setMaxShown( ( shown ) => shown + 12 );
} }
>
<span
Expand Down
2 changes: 1 addition & 1 deletion onboarding/src/scss/_general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ input.components-text-control__input[type="email"],

@mixin ob-general--laptop() {
.ob-sites.is-grid {
grid-template-columns: 1fr 1fr 1fr;
grid-template-columns: repeat(4, minmax(0, 1fr));
}
}

Expand Down
Loading