feat(onboarding): tone down starter-sites listing banners#479
Merged
Conversation
Two banners on the "Choose a design" step were too intrusive. 1. Remove the full-width "80+ new starter sites" promo notice (added in #465) and keep the social proof as a quiet subtitle under the heading: "Nearly 200 starter sites for every niche — fresh designs added regularly." Removes the OnboardingPromoNotice component + SCSS, the SiteList mount, the style import, and the dismiss AJAX handler / show-logic / localization in Admin.php, plus the e2e dismiss test. 2. Make the premium-upsell toast compact (smaller padding/font, capped width, smaller logo, no fixed 70px height) and sharpen the copy: "Unlock every premium template with Neve Business. Upgrade" (was "Unlock Access to all premium templates with Neve Business plan. Get Started."). Note: should_show_business_agency_promo_text() + the onboardingShowProNoticeText localization are now unused (they only varied the removed notice's text); left in place with their unit tests and can be pruned in a follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QrGf4K9upxDKhRPVCztoLs
ineagu
added
enhancement
Collaborator
Applies the workflow-decided implementations for the two onboarding notices,
verified in a local wp-env Neve onboarding instance.
- Subtitle: copy -> "Nearly 200 starter sites across every niche, with dozens
added recently." (truthful, evergreen). Fix a WCAG AA contrast failure:
$secondary-text #848484 (~3.5:1) -> mix(...) ~#6E6D6D (~4.6:1); subtle
weight-only emphasis on the count, plus a small-screen scale step.
- Upsell toast: two-line copy ("Unlock every premium template" /
"Included with Neve Business. <See plans>"), white card, Neve mark scaled
to 24px, role=status + accessible (type=button, aria-label) dismiss,
focus-visible rings, reduced-motion, mobile full-width strip.
- Logo: add viewBox="0 0 40 40" to SVG.logo so it scales instead of cropping
when constrained below 40px (fixes the clipped mark in the toast).
- phpcs: re-align the const block after the promo-notice constant removal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QrGf4K9upxDKhRPVCztoLs
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
HardeepAsrani
approved these changes
Jun 22, 2026
Collaborator
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tones down two intrusive banners on the onboarding "Choose a design" step.
1. The "80+ new starter sites" promo notice → removed, replaced with a subtle subtitle
The full-width brand-color promo block (added in #465) was too in-your-face. Removed it and kept the social proof as a quiet, always-visible subtitle under the heading:
Removed: the
OnboardingPromoNoticecomponent + its SCSS, theSiteListmount, thestyle.scssimport, and the dismiss AJAX handler / show-logic / localization inAdmin.php, plus the e2e dismiss test.2. The premium-upsell toast → compact + sharper copy
The bottom-right toast was a chunky 70px box. Made it compact (smaller padding/font, capped width ~340px, smaller logo, no fixed height) and rewrote the copy with a clearer CTA:
How to test
yarn && yarn build(onboarding bundle;build/is gitignored).Note
should_show_business_agency_promo_text()+ theonboardingShowProNoticeTextlocalization only varied the removed notice's text — they're now unused. Left in place (with their unit tests) to keep this PR focused; can be pruned in a follow-up.Copy/number for the subtitle ("Nearly 200… ") is easy to tweak — say the word.