[WIP] Remove starter site launch onboarding promo notice#486
Closed
Claude wants to merge 2 commits into
Closed
Conversation
Remove all code introduced in PR #465 for the promotional notice: - Remove should_show_business_agency_promo_text() method from Admin.php - Remove onboardingShowProNoticeText localization entry from Admin.php - Remove related unit tests from tests/tc-disabled-test.php Retained code (used elsewhere): - adminUrl localization key: used by Header.js for exit redirect - neve_license_plan() method: used by Sites_Listing.php Closes #485 Agent-Logs-Url: https://github.com/Codeinwp/templates-patterns-collection/sessions/d36058c7-4e87-47f6-9d5d-24269786750d Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR starts removing the starter-site launch onboarding promo notice logic (introduced in PR #465) by deleting the PHP-side “business/agency variant” decision logic and its associated unit tests, reducing promo-notice-specific code paths in the plugin’s admin/onboarding bootstrap.
Changes:
- Removed
Admin::should_show_business_agency_promo_text()and stopped exposing its result viaget_localization(). - Deleted PHPUnit coverage that specifically validated the business/agency promo text branching behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/Admin.php |
Removes the promo-text variant helper and the related localized flag previously exposed to the onboarding UI. |
tests/tc-disabled-test.php |
Removes unit tests and test helpers that targeted the promo notice’s tier-aware text variant logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
23
| public function set_up(): void { | ||
| parent::set_up(); | ||
| $this->admin = new Admin(); | ||
| $this->license = License::get_instance(); | ||
| $this->neve_pro_license_option = 'neve_pro_addon_license_data'; | ||
| } |
Comment on lines
803
to
808
| 'license_id' => License::get_license_data()->key, | ||
| ), | ||
| 'upsellNotifications' => $this->get_upsell_notifications(), | ||
| 'isValidLicense' => $this->has_valid_addons(), | ||
| 'licenseTIOB' => License::get_license_data(), | ||
| 'onboardingShowProNoticeText' => $this->should_show_business_agency_promo_text(), | ||
| 'emailSubscribe' => array( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.