Skip to content

fix: Share as image not working for Twitter #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HardeepAsrani merged 2 commits into from
Jul 11, 2025
Merged

fix: Share as image not working for Twitter #1051

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c36fd53
Update class-rop-twitter-service.php
HardeepAsrani Jul 11, 2025
6775bde
fix: phplint
HardeepAsrani Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions includes/admin/services/class-rop-twitter-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,13 @@ private function twitter_media_post( $post_details, $api ) {
}

$upload_args = array(
'media' => $media_path,
'media_type' => $post_details['mimetype']['type'],
'media' => $media_path,
'media_type' => $post_details['mimetype']['type'],
'media_category' => 'tweet_image',
);

$options['chunkedUpload'] = false;

if ( ! empty( $photon_bypass ) && class_exists( 'Jetpack_Photon' ) ) {
// Re-enable Jetpack Photon filter.
add_filter( 'image_downsize', array( Jetpack_Photon::instance(), 'filter_image_downsize' ), 10, 3 );
Expand All @@ -511,19 +514,20 @@ private function twitter_media_post( $post_details, $api ) {
$upload_args['media_type'] = $post_details['mimetype']['type'];
$upload_args['media_category'] = 'tweet_video';
$status_check = true;
$options['chunkedUpload'] = true;
}

// Overwrite media_type and category if is Gif Post
if ( strpos( $post_details['mimetype']['type'], 'image/gif' ) !== false ) {
$upload_args['media_type'] = $post_details['mimetype']['type'];
$upload_args['media_category'] = 'tweet_gif';
$status_check = true;
$options['chunkedUpload'] = true;
}

$this->logger->info( 'Before upload to twitter . ' . json_encode( $upload_args ) );
$api->setTimeouts( 10, 60 );
$api->setApiVersion( '2' );
$options['chunkedUpload'] = true;
$media_response = $api->upload( 'media/upload', $upload_args, $options );

if ( isset( $media_response->data->id ) ) {
Expand Down
Loading