dev: upgrade phpcs and solve some errors#1062
Open
Soare-Robert-Daniel wants to merge 5 commits intodevelopmentfrom
Open
dev: upgrade phpcs and solve some errors#1062Soare-Robert-Daniel wants to merge 5 commits intodevelopmentfrom
Soare-Robert-Daniel wants to merge 5 commits intodevelopmentfrom
Conversation
Soare-Robert-Daniel
added
the
pr-checklist-skip
Soare-Robert-Daniel
force-pushed
the
dev/tools
branch
from
47da4d6 to
45640d4
Compare
Contributor
HardeepAsrani
approved these changes
Sep 1, 2025
Member
HardeepAsrani
left a comment
HardeepAsrani
left a comment
There was a problem hiding this comment.
Only reviewed the PHPCS changed and not each individual change here, we can also see why the e2e is failing after the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
With the upgraded PHPCS, there are lots of warnings reported.
Will affect the visual aspect of the product
NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes #.