dev: clean up

Author: Soare Robert-Daniel

AGENTS.md

@@ -22,7 +22,7 @@ npm run dist
 
 ```bash
 # PHPUnit — requires Docker (wp-env)
-npm run test:unit:php:setup          # Start WordPress Docker environment
+npm run env:setup          # Start WordPress Docker environment
 bash ./bin/e2e-after-setup.sh        # Prepare database/test data
 npm run test:unit:php                # Run PHPUnit tests
 
@@ -61,14 +61,14 @@ You can read more about it on `./ARCHITECTURE.md`, but here’s a high-level ove
 
 ### Core Classes
 
-| Class | File | Role |
-|---|---|---|
-| `NM_PersonalizedProduct` | `classes/plugin.class.php` | Main plugin — registers all WooCommerce hooks, loads input types |
-| `NM_PersonalizedProduct_Admin` | `classes/admin.class.php` | Admin-only coordinator for menus, settings, attach flows, and admin AJAX |
-| `PPOM_Meta` | `classes/ppom.class.php` | Product-side field-group resolver that reads attached groups and loads settings/fields from the custom DB table |
-| `PPOM_Form` | `classes/form.class.php` | Frontend form rendering |
-| `PPOM_Fields_Meta` | `classes/fields.class.php` | Admin field-builder UI, modals, and builder asset loading |
-| `PPOM_Inputs` | `classes/input.class.php` | Input type manager |
+| Class                          | File                       | Role                                                                                                            |
+| ------------------------------ | -------------------------- | --------------------------------------------------------------------------------------------------------------- |
+| `NM_PersonalizedProduct`       | `classes/plugin.class.php` | Main plugin — registers all WooCommerce hooks, loads input types                                                |
+| `NM_PersonalizedProduct_Admin` | `classes/admin.class.php`  | Admin-only coordinator for menus, settings, attach flows, and admin AJAX                                        |
+| `PPOM_Meta`                    | `classes/ppom.class.php`   | Product-side field-group resolver that reads attached groups and loads settings/fields from the custom DB table |
+| `PPOM_Form`                    | `classes/form.class.php`   | Frontend form rendering                                                                                         |
+| `PPOM_Fields_Meta`             | `classes/fields.class.php` | Admin field-builder UI, modals, and builder asset loading                                                       |
+| `PPOM_Inputs`                  | `classes/input.class.php`  | Input type manager                                                                                              |
 
 ### Input Type System
 
@@ -77,6 +77,7 @@ Each input type has a class in `classes/inputs/` (e.g. `input.text.php`, `input.
 ### Include Files (`inc/`)
 
 Procedural utility code organized by concern:
+
 - `functions.php` — general helpers
 - `hooks.php` — filter/action callbacks
 - `validation.php` — server-side field validation

CONTRIBUTING.md

@@ -83,7 +83,7 @@ To set-up the environment you can follow the example from `test-php.yml` or the
 To run with Docker:
 
 ```bash
-npm run test:unit:php:setup # start the wordpress instance
+npm run env:setup # start the wordpress instance
 npm run test:unit:php # run the wp tests inside the tests-wordpress container
 ```
 

bin/e2e-after-setup.sh

@@ -719,8 +719,8 @@ public function ppom_attach_ppoms() {
 	/**
 	 * Stores category and tag attachment rules on a PPOM field-group row.
 	 *
-	 * @param int        $ppom_id    PPOM field-group ID.
-	 * @param array      $categories Category slugs attached to the field group.
+	 * @param int         $ppom_id    PPOM field-group ID.
+	 * @param array       $categories Category slugs attached to the field group.
 	 * @param array|false $tags      Serialized tag slugs, an empty array to clear tags, or false to leave tags unchanged.
 	 *
 	 * @return void
@@ -734,7 +734,7 @@ public static function save_categories_and_tags( $ppom_id, $categories, $tags )
 		);
 
 		// false = caller chose not to change tags (e.g. E2E partial update); omit column from UPDATE.
-		if ( false !== $tags && is_array( $tags ) ) {
+		if ( is_array( $tags ) ) {
 			$data_to_update['productmeta_tags'] = empty( $tags ) ? '' : serialize( $tags );
 		}
 

classes/admin.class.php

@@ -37,10 +37,9 @@
     "build:grunt": "grunt build",
     "grunt": "grunt",
     "wp-env": "wp-env",
-    "env:after:setup": "bash ./bin/e2e-after-setup.sh",
     "test:e2e": "wp-scripts test-playwright --config tests/e2e/playwright.config.js",
     "test:e2e:debug": "wp-scripts test-playwright --config tests/e2e/playwright.config.js --ui",
-    "test:unit:php:setup": "wp-env start",
+    "env:setup": "wp-env start",
     "test:unit:php:setup:debug": "wp-env start --xdebug",
     "test:unit:php": "wp-env run --env-cwd='wp-content/plugins/woocommerce-product-addon' tests-wordpress vendor/bin/phpunit -c phpunit.xml --verbose",
     "lint": "wp-scripts lint-js ./js/",

package.json

@@ -125,7 +125,7 @@
 <violation file="classes/admin.class.php" sniff="WordPress.DB.DirectDatabaseQuery.NoCaching" signature="04f6dc51ac2a8f6ce38ea8879a1df7cfb2f4db78"/>
 <violation file="classes/admin.class.php" sniff="WordPress.DB.DirectDatabaseQuery.NoCaching" signature="7265beead929a772a1a31bc295ca76457115e661"/>
 <violation file="classes/admin.class.php" sniff="WordPress.DB.PreparedSQL.InterpolatedNotPrepared" signature="868feaab2785372f9df272040e1cf939f32fab03"/>
-<violation file="classes/admin.class.php" sniff="WordPress.PHP.DiscouragedPHPFunctions.serialize_serialize" signature="88018cf90cd92ed1f116de38b4a7e1dc1e528a9f"/>
+<violation file="classes/admin.class.php" sniff="WordPress.PHP.DiscouragedPHPFunctions.serialize_serialize" signature="ac0d71a81281dc15efeeb74049d688f26c968b94"/>
 <violation file="classes/admin.class.php" sniff="WordPress.Security.EscapeOutput.OutputNotEscaped" signature="0887cf1c16ff27aa23a654fc7e1828f70bf6557a"/>
 <violation file="classes/admin.class.php" sniff="WordPress.Security.EscapeOutput.OutputNotEscaped" signature="145c3a2f9b92e01afc5d6911c7bdc0f122816d98"/>
 <violation file="classes/admin.class.php" sniff="WordPress.Security.EscapeOutput.OutputNotEscaped" signature="78682f38a10b1192e8a8ea1773ddb2d7ca43c4e6"/>