dev: add centralized repository for db access

Author: Soare Robert-Daniel

bin/wp-env/mu-plugins/ppom-e2e-bootstrap.php

@@ -510,22 +510,14 @@ function ppom_e2e_insert_ppom_group( $args ) {
 
 	$dt = apply_filters( 'ppom_settings_meta_data_new', $ppom_settings_meta_data );
 
-	global $wpdb;
-	$ppom_table = $wpdb->prefix . PPOM_TABLE_META;
-	$inserted   = $wpdb->insert(
-		$ppom_table,
-		$dt,
-		array_fill( 0, count( $dt ), '%s' )
-	);
+	$ppom_id = ppom_meta_repository()->insert_group( $dt, array_fill( 0, count( $dt ), '%s' ) );
 
-	if ( false === $inserted ) {
+	if ( $ppom_id <= 0 ) {
 		return new WP_Error(
 			'meta_insert_failed',
 			__( 'PPOM group could not be saved.', 'woocommerce-product-addon' )
 		);
 	}
-
-	$ppom_id      = (int) $wpdb->insert_id;
 	$final_fields = ppom_e2e_prepare_form_meta_fields( $ppom_fields, $ppom_id );
 
 	if ( is_wp_error( $final_fields ) ) {
@@ -766,16 +758,7 @@ function ppom_e2e_get_ppom_attach_row() {
 		);
 	}
 
-	global $wpdb;
-
-	$table = $wpdb->prefix . PPOM_TABLE_META;
-	$row   = $wpdb->get_row(
-		$wpdb->prepare(
-			"SELECT productmeta_categories, productmeta_tags FROM {$table} WHERE productmeta_id = %d",
-			$ppom_id
-		),
-		ARRAY_A
-	);
+	$row = ppom_meta_repository()->get_categories_and_tags_columns( $ppom_id );
 
 	if ( empty( $row ) || ! is_array( $row ) ) {
 		wp_send_json_error(
@@ -1164,16 +1147,7 @@ function ppom_e2e_reset_state() {
 	$tracked_meta_ids  = ppom_e2e_get_tracked_meta_ids();
 
 	if ( ! empty( $tracked_meta_ids ) && defined( 'PPOM_TABLE_META' ) ) {
-		global $wpdb;
-
-		$ppom_table     = $wpdb->prefix . PPOM_TABLE_META;
-		$placeholders   = implode( ',', array_fill( 0, count( $tracked_meta_ids ), '%d' ) );
-		$deleted_result = $wpdb->query(
-			$wpdb->prepare(
-				"DELETE FROM {$ppom_table} WHERE productmeta_id IN ({$placeholders})",
-				$tracked_meta_ids
-			)
-		);
+		$deleted_result = ppom_meta_repository()->delete_by_ids( $tracked_meta_ids );
 
 		if ( false !== $deleted_result ) {
 			$deleted_meta_rows = (int) $deleted_result;

classes/admin.class.php

@@ -591,17 +591,9 @@ public function get_wc_tags( $current_values ) {
 	 * @return array
 	 */
 	public function get_db_field( $ppom_field_id ) {
-		global $wpdb;
-		$ppom_table = $wpdb->prefix . PPOM_TABLE_META;
-		$rows       = $wpdb->get_results(
-			$wpdb->prepare(
-				"SELECT productmeta_categories, productmeta_tags FROM $ppom_table WHERE productmeta_id = %d",
-				$ppom_field_id
-			),
-			ARRAY_A
-		);
+		$rows = ppom_meta_repository()->get_categories_and_tags_columns( (int) $ppom_field_id );
 
-		return 0 < count( $rows ) && ! empty( $rows[0] ) ? $rows[0] : array();
+		return ! empty( $rows ) ? $rows : array();
 	}
 
 	/**
@@ -720,25 +712,7 @@ public function ppom_attach_ppoms() {
 	 * @return void
 	 */
 	public static function save_categories_and_tags( $ppom_id, $categories, $tags ) {
-		global $wpdb;
-		$ppom_table = $wpdb->prefix . PPOM_TABLE_META;
-
-		$data_to_update = array(
-			'productmeta_categories' => implode( "\r\n", $categories ), // NOTE: Keep the backward compatible format.
-		);
-
-		// false = caller chose not to change tags (e.g. E2E partial update); omit column from UPDATE.
-		if ( is_array( $tags ) ) {
-			$data_to_update['productmeta_tags'] = empty( $tags ) ? '' : serialize( $tags );
-		}
-
-		$wpdb->update(
-			$ppom_table,
-			$data_to_update,
-			array( 'productmeta_id' => $ppom_id ), // Where clause
-			array( '%s' ), // Data format
-			array( '%d' )  // Where format
-		);
+		ppom_meta_repository()->save_categories_and_tags( (int) $ppom_id, $categories, $tags );
 	}
 
 	// Legacy settings bridge and setup.
@@ -955,10 +929,7 @@ public function set_legacy_user() {
 			return;
 		}
 
-		global $wpdb;
-		$ppom_meta_table = $wpdb->prefix . PPOM_TABLE_META;
-		// phpcs:ignore WordPress.DB.DirectDatabaseQuery, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
-		$res = $wpdb->get_results( "SELECT * FROM `$ppom_meta_table` WHERE `productmeta_js` != '' OR `productmeta_style` != ''" );
+		$res = ppom_meta_repository()->get_rows_with_non_empty_style_or_js();
 		update_option( 'ppom_legacy_user', ! empty( $res ) ? 'yes' : 'no' );
 	}