dev: update dev packages & format file by Soare-Robert-Daniel · Pull Request #534 · Codeinwp/woocommerce-product-addon

Soare-Robert-Daniel · 2026-03-25T14:09:29Z

Summary

Update all the dev packages.
Apply formatting and some linting
Restructure the E2E around PHP fixtures (and also a helping plugin) that help with constructing complex cases.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

Check if the build is fine.

Check before Pull Request is ready:

I have written a test and included it in this PR
I have run all tests and they pass
The code passes when running the PHP CodeSniffer
Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
Security and Sanitization requirements have been followed
I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes #.

pirate-bot · 2026-03-25T14:11:52Z

Plugin build for fd75028 is ready 🛎️!

Download PPOM - build 🔗

Copilot

Pull request overview

Updates PPOM’s development tooling and applies broad formatting/docblock cleanup across JS/PHP, plus CI/workflow adjustments.

Changes:

Bumps/adjusts dev tooling (Composer scripts/deps, PHPCS baseline support) and updates CI to use npm + newer Node versions.
Reformats and documents multiple frontend/admin JS modules and many PHP files (docblocks, arrays, small refactors).
Adds/revises repo tooling/config files (ESLint/Prettier ignores, wp-env config, distignore entries, Copilot workflow).

Reviewed changes

Copilot reviewed 88 out of 164 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
js/validate.js	Formatting and minor refactors in required-field validation logic
js/ppom-validation.js	AJAX add-to-cart validation formatting + small control flow update
js/ppom-tooltip.js	Tooltip script formatting + documentation header
js/ppom-simple-popup.js	Popup/tooltip bridge formatting + tooltip init guard
js/ppom-plusminus.js	Plus/minus widget formatting and minor refactors
js/ppom-conditions.js	Legacy conditions engine formatted + documented
js/popup.js	Admin popup documentation + typing annotations/cleanup
js/image-tooltip.js	Image tooltip formatting + documentation header
js/admin/serializejson.js	Reformat vendored serializeJSON plugin for readability
js/admin/pre-load.js	Preloader formatting + doc header
js/admin/ppom-meta-table.js	Admin meta table refactor + popup-based confirmations
js/admin/ppom-deactivate.js	Deactivation modal formatting + doc header
js/admin/ppom-bulkquantity.js	Bulk quantity admin editor refactor + doc/typedef additions
inc/woocommerce.php	Adds docblocks/sections and normalizes array syntax/formatting
inc/validation.php	Adds docblocks and refactors sanitization helper signature/logic
inc/rest.class.php	Adds docblocks/visibility updates and improves order meta formatting safety
inc/prices.php	Adds docblocks/sections and normalizes formatting/increments
inc/nmInput.class.php	Formatting tweaks; minor control-flow simplification
inc/hooks.php	Adds docblocks/sections and normalizes formatting/increments
inc/functions.php	Docblocks + small control-flow simplification
inc/files.php	Adds docblocks/sections and normalizes formatting/increments
inc/arrays.php	Formatting tweaks (alignment/trailing commas)
inc/admin.php	Adds docblocks; improves nonce handling/normalization and formatting
grunt/addtextdomain.js	Formatting cleanup
composer.json	Adds lint/format scripts, bumps phpstan config, updates platform PHP + dev deps
classes/survey.class.php	Formatting (comma/trailing comma)
classes/ppom.class.php	Adds docblocks/visibility; formatting and minor array normalizations
classes/plugin.class.php	Adds docblocks; formatting/increment tweaks
classes/legacy-meta.class.php	Braces/formatting cleanup
classes/integrations/elementor/shortcode-widget.php	Switches to long array syntax for compatibility/style
classes/integrations/elementor/elementor.class.php	Switches callbacks to long array syntax
classes/inputs/input.timezone.php	Minor formatting cleanup
classes/inputs/input.textarea.php	Minor formatting cleanup
classes/inputs/input.text.php	Minor formatting cleanup
classes/inputs/input.select.php	Minor formatting cleanup
classes/inputs/input.section.php	Minor formatting cleanup
classes/inputs/input.radio.php	Minor formatting cleanup
classes/inputs/input.quantities.php	Minor formatting cleanup
classes/inputs/input.pricematrix.php	Minor formatting cleanup
classes/inputs/input.palettes.php	Minor formatting cleanup
classes/inputs/input.number.php	Minor formatting cleanup
classes/inputs/input.image.php	Minor formatting cleanup
classes/inputs/input.hidden.php	Minor formatting cleanup
classes/inputs/input.file.php	Minor formatting cleanup
classes/inputs/input.email.php	Minor formatting cleanup
classes/inputs/input.divider.php	Minor formatting cleanup
classes/inputs/input.daterange.php	Minor formatting cleanup
classes/inputs/input.date.php	Minor formatting cleanup
classes/inputs/input.cropper.php	Minor formatting cleanup
classes/inputs/input.color.php	Minor formatting cleanup
classes/inputs/input.checkbox.php	Minor formatting cleanup
classes/inputs/input.audio.php	Minor formatting cleanup
classes/input.class.php	Adds docblocks and clarifies responsibilities
classes/input-meta.class.php	Switches short arrays to long arrays for consistency
classes/frontend-scripts.class.php	Adds docblocks/sections; formatting and increment tweaks
classes/freemium.class.php	Braces/arrays formatting improvements
classes/form.class.php	Docblocks + formatting and array syntax normalization
classes/fields.class.php	Docblocks + refactors around asset loading/localization and builder rendering
classes/attach-popup/select-component.class.php	Output formatting/escaping consistency improvements
classes/admin.class.php	Docblocks/visibility improvements and formatting across attach/settings flows
backend/templates/admin-settings.php	Uses printf with clearer formatting for upsell notices
backend/settings-panel.class.php	Docblocks + long array defaults and minor refactors
backend/options.php	Docblocks + long array syntax in option definitions
backend/changelog_handler.php	Normalizes return values/arrays and formatting
Gruntfile.js	Formatting cleanup and minor structure normalization
AGENTS.md	Updates docs for new tooling, security guidance, and PHP min info
.wp-env.json	Adds schema + autoPort; changes WooCommerce plugin download
.prettierignore	Adds ignore patterns for generated/vendor assets
.github/workflows/test-php.yml	Switches to npm + newer node; adds PHPCS job; adjusts action versions
.github/workflows/sync-wporg-assets.yml	Quote/style normalization
.github/workflows/sync-branches.yml	Quote/style normalization
.github/workflows/e2e.yml	Switches to npm + newer node; adjusts action versions
.github/workflows/deploy-svn.yml	Switches build steps from yarn to npm
.github/workflows/deploy-s3-store.yml	Switches build steps from yarn to npm; bumps node
.github/workflows/create-tag.yml	Switches build steps from yarn to npm; bumps node
.github/workflows/create-build-zip.yml	Switches build steps from yarn to npm; bumps node
.github/workflows/copilot.yml	Adds agent setup workflow steps for Copilot runs
.eslintrc.json	Adds WordPress ESLint preset config and ignores
.distignore	Adds new dev config files to distignore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    name: PHPCS
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup PHP version
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "7.4"
+          extensions: simplexml
+      - name: Checkout source code
+        uses: actions/checkout@master
+      - name: Install composer
+        run: |
+          composer install --no-progress
+      - name: Run linter for PHP
+        run: composer run lint


+						'<input checked="checked" name="ppom[fields][' +
+							field_name +
+							'][' +
+							image_id +
+							'][cropped]" type="checkbox"/>'


+			case 'is':
+				if ( element_type === 'checkbox' ) {
+					var element_value = ppom_get_element_value( rule.elements );
+					jQuery( element_value ).each( function ( i, item ) {


+					} );
+				} else if ( element_type === 'image' ) {
+					var element_value = ppom_get_element_value( rule.elements );
+					jQuery( element_value ).each( function ( i, item ) {


+			case 'not':
+				if ( element_type === 'checkbox' ) {
+					var element_value = ppom_get_element_value( rule.elements );
+					jQuery( element_value ).each( function ( i, item ) {


+			case 'greater than':
+				if ( element_type === 'checkbox' ) {
+					var element_value = ppom_get_element_value( rule.elements );
+					jQuery( element_value ).each( function ( i, item ) {


+			case 'less than':
+				if ( element_type === 'checkbox' ) {
+					var element_value = ppom_get_element_value( rule.elements );
+					jQuery( element_value ).each( function ( i, item ) {


Copilot

Pull request overview

Copilot reviewed 88 out of 166 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T12:55:49Z

+		);
+		this.text.classList.toggle(
+			'ppom-hide',
+			Boolean( options?.text?.length )


this.text.classList.toggle('ppom-hide', Boolean(options?.text?.length)) will hide the text element when text is provided (since the second arg is true). This looks inverted for a ppom-hide class; it should typically hide when there is no text. Flip the condition so the text is hidden only when options.text is empty/absent.

Suggested change

Boolean( options?.text?.length )

! options?.text?.length

Copilot · 2026-04-02T12:55:49Z

+	// modal behavior, while others use it to initialize tooltip-enabled inputs.
+	if ( $( '[data-ppom-tooltip~=ppom_tooltip]' ).length > 0 ) {
+		$( '[data-ppom-tooltip~=ppom_tooltip]' ).ppom_tooltipster?.(
+			tooltip_options
+		);
 	}


This introduces optional chaining (?.) in a frontend asset. If these scripts are shipped without transpilation, optional chaining can cause a hard syntax error in older browsers and prevent the entire file from executing. Prefer a feature check (e.g., verify the plugin function exists) without optional chaining to keep runtime compatibility consistent with the rest of the bundle.

Copilot · 2026-04-02T12:55:49Z

+      - uses: actions/checkout@master
+      - uses: actions/setup-node@v6


Using actions/checkout@master (and similarly other @master action references in this PR) is a supply-chain risk and can introduce unexpected breaking changes. Pin actions to a stable major tag (e.g., actions/checkout@v4) or a specific commit SHA to make CI reproducible and safer.

Copilot · 2026-04-02T12:55:50Z

-}
+  "$schema": "https://schemas.wp.org/trunk/wp-env.json",
+  "plugins": [
+      "https://downloads.wordpress.org/plugin/woocommerce.zip",


Switching from a pinned WooCommerce version ZIP to the floating woocommerce.zip makes local/E2E environments non-reproducible (the installed WooCommerce version can change over time and break tests/builds). Consider pinning a specific WooCommerce version (as before) or explicitly documenting that wp-env uses a moving target.

Suggested change

"https://downloads.wordpress.org/plugin/woocommerce.zip",

"https://downloads.wordpress.org/plugin/woocommerce.8.6.1.zip",

Soare Robert-Daniel added 6 commits March 25, 2026 14:16

dev: update phpstan

b20433e

dev: upgrade PHP linting

f5fd1f8

dev: format PHP files

2be811b

dev: update packages & remove yarn

a8739f0

dev: upgrade js dev packages

61c7985

dev: format js files

76fae4f

Soare-Robert-Daniel self-assigned this Mar 25, 2026

Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 25, 2026

pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Mar 25, 2026

Soare Robert-Daniel added 19 commits March 25, 2026 16:13

dev: ignore minified files

8c54b69

dev: wp env

5a22f12

dev: add docs and tweaks

6db0659

dev: extend docs

09e31aa

dev: clean up docs

008d350

dev: fix e2e

4d8c184

dev: add E2E test

731a2ca

dev: add E2E tests

b810a35

dev: phpcs & phpstan

b4b484c

dev: CI

bb41d96

dev: CI

c485d7e

dev: expands unit tests

9cc78ab

dev: expands unit tests

26422e0

dev: reset

d777e1d

dev: expand unit tests

8575c20

dev: use E2E fixtures

d1f44d0

dev: extend tests

46d250c

dev: extend tests

760444c

dev: wp env

a3857be

Soare-Robert-Daniel requested a review from Copilot April 1, 2026 14:19

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Comment thread js/popup.js

Comment thread .github/workflows/copilot-setup-steps.yml

Comment thread .wp-env.json

Comment thread inc/validation.php

Comment thread js/validate.js Outdated

Comment thread inc/woocommerce.php Outdated

Comment thread js/admin/ppom-meta-table.js Outdated

Soare Robert-Daniel added 2 commits April 1, 2026 17:27

dev: phpstan

efb3f18

chore: code review

e064d0b

Soare-Robert-Daniel requested a review from HardeepAsrani April 2, 2026 09:01

dev: add special bootstrap plugin for e2e fixtures

da2adda

github-advanced-security AI found potential problems Apr 2, 2026

View reviewed changes

dev: extend e2e tests

fb82089

Soare-Robert-Daniel requested a review from Copilot April 2, 2026 12:53

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Soare Robert-Daniel added 4 commits April 3, 2026 14:41

Merge branch 'development' into dev/format

f29f108

dev: add more e2e tests based on the merging

4fc195f

dev: add a fixture for license toggle

45d2eb4

dev: clean up

1ff6f27

Soare-Robert-Daniel force-pushed the dev/format branch from 0fbaaa7 to 1ff6f27 Compare April 3, 2026 14:00

Soare Robert-Daniel added 2 commits April 6, 2026 10:46

dev: clean up

39bffb1

dev: clean up

fd75028

Soare-Robert-Daniel requested review from abaicus and removed request for HardeepAsrani April 6, 2026 08:36

abaicus approved these changes Apr 7, 2026

View reviewed changes

Soare-Robert-Daniel merged commit b9c976c into development Apr 7, 2026
10 of 11 checks passed

Soare-Robert-Daniel deleted the dev/format branch April 7, 2026 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev: update dev packages & format file#534

dev: update dev packages & format file#534
Soare-Robert-Daniel merged 35 commits intodevelopmentfrom
dev/format

Soare-Robert-Daniel commented Mar 25, 2026 •

edited

Loading

Uh oh!

pirate-bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		- uses: actions/checkout@master
		- uses: actions/setup-node@v6

	"https://downloads.wordpress.org/plugin/woocommerce.zip",
	"https://downloads.wordpress.org/plugin/woocommerce.8.6.1.zip",

Conversation

Soare-Robert-Daniel commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Will affect visual aspect of the product

Screenshots

Test instructions

Check before Pull Request is ready:

Uh oh!

pirate-bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Soare-Robert-Daniel commented Mar 25, 2026 •

edited

Loading

pirate-bot commented Mar 25, 2026 •

edited

Loading