Fixed various bugs

[girishpanchal30]

Check before Pull Request is ready:

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR

Closes https://github.com/Codeinwp/ppom-pro/issues/652

[pirate-bot]

Tip

You can preview the changes in the Playground

Plugin build for a5279ff is ready 🛎️!

• Download PPOM - build 🔗

[Copilot]

Pull request overview

Fixes several PPOM field-group edge cases (notably around multiple attached groups and imported/legacy data) to address reported bugs in issue #652.

Changes:

• Add meta-id cleanup logic while loading fields and extend inline CSS/JS generation to support multiple PPOM groups.
• Adjust frontend field filtering to tolerate imported fields missing ppom_id.
• Prevent PHP notices in the conditional-logic admin UI by guarding selected() calls with isset().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
classes/ppom.class.php	Cleans up invalid attached group ids and aggregates inline CSS/JS across multiple groups.
classes/form.class.php	Changes per-group field filtering behavior to handle missing ppom_id.
classes/fields.class.php	Hardens conditional-rule select rendering against missing array keys (avoids notices).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[poonam279]

@girishpanchal30 I’m not able to test this build because, after installing it, I can’t edit any PPOM field.

I’m seeing this fatal error:

PHP Fatal error: Uncaught Error: Too few arguments to function PPOM_Meta::generate_inline_css(), 0 passed in /s3-unpacksand/wordpress/wp-content/plugins/woocommerce-product-addon/classes/ppom.class.php on line 154 and exactly 1 expected

[girishpanchal30]

@poonam279 I have fixed it with the latest commit. Please check it and let me know if any changes are needed. Thanks!

[poonam279]

@girishpanchal30, I tested this and found these two things:

1. On products with multiple field groups, CSS handling is still incorrect — styles from the first group appear to affect other groups, instead of each group using only its own custom CSS.
2. After importing data, some condition rule options were altered, and some values became empty

[girishpanchal30]

@poonam279

On products with multiple field groups, CSS handling is still incorrect — styles from the first group appear to affect other groups, instead of each group using only its own custom CSS.

I have fixed it with the latest commit. Please check it.

After importing data, some condition rule options were altered, and some values became empty

For this issue, could you please share the CSV file or your instance details? I’m unable to reproduce it.

[poonam279]

@girishpanchal30, I checked the latest commit, and it fixed the CSS handling issue.

Regarding the import data, I checked my exported file and found that the conditions were missing/incorrect there as well. After investigating further, I found that the issue is related to saving the conditions.

If we add a condition to just one field , it didn't save. However, after adding a condition to a second field, the new condition overrides the previous condition on the other field.

Here is a video demonstrating the issue: https://vertis.d.pr/v/38yM2u

There is another scenario as well: if a field has only one option and we use it in a condition, the condition gets deleted after saving. Here is the video: https://vertis.d.pr/v/RaWt0k

[girishpanchal30]

@poonam279, I have fixed it with the latest commit. Please check it and let me know if any changes are needed.