Skip to content

Commit 1bf1840

Browse files
CoderCococlaude
andcommitted
ci(e2e): add @electron/get debug logging to diagnose binary download
The forced install.js still produced no path.txt and exited 0 silently, so the download is being skipped/failing inside @electron/get rather than at the skip-flag gate. Enable DEBUG=@electron/get:* and dump the electron dir state to capture the actual cause in CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent d980e0b commit 1bf1840

1 file changed

Lines changed: 14 additions & 12 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,25 @@ jobs:
2424
- run: npm ci
2525

2626
- name: Install Electron binary
27-
# The runner's npm ci leaves node_modules/electron without a path.txt
28-
# (the postinstall binary download is skipped — the runner environment
29-
# carries ELECTRON_SKIP_BINARY_DOWNLOAD), so the electron-smoke spec's
30-
# `_electron.launch()` -> require('electron/index.js') throws "Electron
31-
# failed to install correctly". Force a clean download here with the
32-
# skip flag explicitly cleared, then assert path.txt exists so any
33-
# future regression fails loudly at this step rather than mid-test.
27+
# npm ci leaves node_modules/electron without a path.txt, so the
28+
# electron-smoke spec's `_electron.launch()` -> require('electron/index.js')
29+
# throws "Electron failed to install correctly". Force a clean download
30+
# with @electron/get debug logging so we can see exactly what happens,
31+
# then assert path.txt exists.
3432
env:
3533
ELECTRON_SKIP_BINARY_DOWNLOAD: ''
34+
DEBUG: '@electron/get:*'
3635
run: |
37-
cat node_modules/electron/path.txt 2>/dev/null \
38-
&& echo " <- path.txt present after npm ci" \
39-
|| echo "no path.txt after npm ci"
4036
rm -rf node_modules/electron/dist node_modules/electron/path.txt
37+
set +e
4138
node node_modules/electron/install.js
42-
cat node_modules/electron/path.txt && echo " <- path.txt written"
43-
node -e "console.log('electron resolves to:', require('electron/index.js'))"
39+
echo "==== install.js exit=$? ===="
40+
set -e
41+
echo "==== node_modules/electron contents ===="
42+
ls -la node_modules/electron/
43+
echo "==== dist contents ===="
44+
ls -la node_modules/electron/dist/ 2>/dev/null || echo "NO dist/"
45+
test -f node_modules/electron/path.txt
4446
timeout-minutes: 5
4547

4648
# No explicit desktop:build step: @hyveon/web's `test:e2e` script always

0 commit comments

Comments
 (0)