Skip to content

Commit 27b038e

Browse files
committed
ci: split Playwright install into deps + binary steps with timeouts
--with-deps in a single step was hanging silently. Split into: - install-deps (DEBIAN_FRONTEND=noninteractive, 5min timeout) - install binary (5min timeout) Added job-level timeout-minutes: 20 so hung jobs fail fast. Refs #144
1 parent 2c8fc40 commit 27b038e

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ permissions:
1111
jobs:
1212
e2e:
1313
runs-on: ubuntu-latest
14+
timeout-minutes: 20
1415
steps:
1516
- uses: actions/checkout@v5
1617

@@ -28,9 +29,15 @@ jobs:
2829
path: ~/.cache/ms-playwright
2930
key: playwright-chromium-${{ runner.os }}-${{ hashFiles('app/packages/web/package-lock.json', 'package-lock.json') }}
3031

31-
- name: Install Playwright browsers
32-
run: npx playwright install chromium --with-deps
32+
- name: Install Playwright system dependencies
33+
run: DEBIAN_FRONTEND=noninteractive npx playwright install-deps chromium
3334
working-directory: app/packages/web
35+
timeout-minutes: 5
36+
37+
- name: Install Playwright browser binaries
38+
run: npx playwright install chromium
39+
working-directory: app/packages/web
40+
timeout-minutes: 5
3441

3542
- run: npm run app:test:e2e
3643

.github/workflows/integration.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ permissions:
1111
jobs:
1212
integration:
1313
runs-on: ubuntu-latest
14+
timeout-minutes: 20
1415
steps:
1516
- uses: actions/checkout@v5
1617

@@ -28,9 +29,15 @@ jobs:
2829
path: ~/.cache/ms-playwright
2930
key: playwright-chromium-${{ runner.os }}-${{ hashFiles('app/packages/web/package-lock.json', 'package-lock.json') }}
3031

31-
- name: Install Playwright browsers
32-
run: npx playwright install chromium --with-deps
32+
- name: Install Playwright system dependencies
33+
run: DEBIAN_FRONTEND=noninteractive npx playwright install-deps chromium
3334
working-directory: app/packages/web
35+
timeout-minutes: 5
36+
37+
- name: Install Playwright browser binaries
38+
run: npx playwright install chromium
39+
working-directory: app/packages/web
40+
timeout-minutes: 5
3441

3542
- run: npm run app:test:integration
3643

0 commit comments

Comments
 (0)