Skip to content

Commit b132b30

Browse files
committed
ci: disable video recording in CI; remove ffmpeg install step
npx playwright install hangs post-download on ubuntu-latest regardless of binary size. Video is not needed in CI — traces retain-on-failure are sufficient for debugging. Locally video still records on failure. Refs #144
1 parent 93314d4 commit b132b30

4 files changed

Lines changed: 4 additions & 10 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ jobs:
2828
working-directory: app/packages/web
2929
timeout-minutes: 5
3030

31-
- name: Install Playwright ffmpeg
32-
run: npx playwright install ffmpeg
33-
working-directory: app/packages/web
34-
timeout-minutes: 3
3531

3632
- run: npm run app:test:e2e
3733

.github/workflows/integration.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ jobs:
2828
working-directory: app/packages/web
2929
timeout-minutes: 5
3030

31-
- name: Install Playwright ffmpeg
32-
run: npx playwright install ffmpeg
33-
working-directory: app/packages/web
34-
timeout-minutes: 3
3531

3632
- run: npm run app:test:integration
3733

app/packages/web/playwright.config.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ export default defineConfig({
1212
use: {
1313
baseURL: 'http://localhost:4173',
1414
trace: 'retain-on-failure',
15-
video: 'retain-on-failure',
15+
// Video requires ffmpeg which hangs on install in CI; traces are sufficient
16+
video: process.env.CI ? 'off' : 'retain-on-failure',
1617
},
1718
projects: [
1819
{

app/packages/web/playwright.integration.config.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ export default defineConfig({
1919
use: {
2020
baseURL: 'http://localhost:4174',
2121
trace: 'retain-on-failure',
22-
video: 'retain-on-failure',
22+
// Video requires ffmpeg which hangs on install in CI; traces are sufficient
23+
video: process.env.CI ? 'off' : 'retain-on-failure',
2324
},
2425
projects: [
2526
{

0 commit comments

Comments
 (0)