fix(setup): run npm commands from repo root after workspace promotion#131
Merged
Merged
Conversation
setup.sh bootstrap() and deploy() were still cd-ing into app/ and calling `npm run build:lambdas` — both wrong after PR #53 promoted the workspace root from app/ to the repo root. - Change `cd "$SCRIPT_DIR/app"` → `cd "$SCRIPT_DIR"` in both functions - Rename `build:lambdas` → `app:build:lambdas` to match the root workspace script name - Remove app/package-lock.json (stale lockfile, predates the workspace-root promotion; the authoritative one is at repo root) Closes #130 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the setup helper to run npm installs/builds from the repo root (the current npm workspace root), avoiding dependency hoisting issues and aligning script invocations with the root-level aliases.
Changes:
- Run
npm ciand Lambda builds from$SCRIPT_DIR(repo root) instead of$SCRIPT_DIR/app. - Switch Lambda build invocation to
npm run app:build:lambdasand update the printed dev “next steps” command tonpm run app:dev. - Remove the stale
app/package-lock.jsonto prevent installs from targeting an orphaned lockfile.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.sh | Runs installs/builds from the workspace root and updates script/printed commands to root-level aliases. |
| app/package-lock.json | Removes an orphaned lockfile that could cause npm ci to run in the wrong directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
Summary
bootstrap()anddeploy()insetup.shwere bothcd-ing intoapp/and callingnpm run build:lambdas, left over from before PR build(workspaces): promote repo root to npm workspace root #53 promoted the npm workspace root fromapp/to the repo rootcd "$SCRIPT_DIR/app"→cd "$SCRIPT_DIR"in both functions sonpm ciruns from the workspace root and correctly hoists all dependenciesnpm run build:lambdas→npm run app:build:lambdasto match the root-level script aliascd app && npm run dev→npm run app:dev)app/package-lock.json— orphaned lockfile from before the workspace root promotion that could confuse npmTest plan
./setup.shon a clean clone — confirmnpm cisucceeds at the repo root and Lambda bundles build without TS2307 errors./setup.sh deploy— confirmnpm run app:build:lambdasruns successfully from the repo rootapp/package-lock.jsonis gone andnpm ciat repo root still resolves all workspace deps correctly