feat: move the version file folder to the Configs/Resources folder

Author: Miguel Cartier

Editor/VersionEditorUtils.cs

@@ -12,6 +12,8 @@ namespace GameLovers.Services.Editor
 	public static class VersionEditorUtils
 	{
 		private const int ShortenedCommitLength = 8;
+		private const string AssetsPath = "Assets";
+		private const string FilePath = "Configs/Resources";
 
 		/// <summary>
 		/// Set the internal version before building the app.
@@ -110,10 +112,7 @@ private static VersionServices.VersionData GenerateInternalVersionSuffix(bool is
 		/// </summary>
 		private static void SaveVersionData(string serializedData)
 		{
-			const string assets = "Assets";
-			const string resources = "Build/Resources";
-
-			var absDirPath = Path.Combine(Application.dataPath, resources);
+			var absDirPath = Path.Combine(Application.dataPath, FilePath);
 			if (!Directory.Exists(absDirPath))
 			{
 				Directory.CreateDirectory(absDirPath);
@@ -125,7 +124,7 @@ private static void SaveVersionData(string serializedData)
 			if (File.Exists(Path.ChangeExtension(absFilePath, assetExtension)))
 			{
 				AssetDatabase.DeleteAsset(
-					Path.Combine(assets, resources,
+					Path.Combine(AssetsPath, FilePath,
 						Path.ChangeExtension(VersionServices.VersionDataFilename, assetExtension)));
 			}
 
@@ -134,7 +133,7 @@ private static void SaveVersionData(string serializedData)
 			File.WriteAllText(Path.ChangeExtension(absFilePath, textExtension), serializedData);
 
 			AssetDatabase.ImportAsset(
-				Path.Combine(assets, resources,
+				Path.Combine(AssetsPath, FilePath,
 					Path.ChangeExtension(VersionServices.VersionDataFilename, textExtension)));
 		}
 	}

Runtime/TickService.cs

@@ -301,11 +301,16 @@ private void OnFixedUpdate()
 				return;
 			}
 
-			var arrayCopy = _onFixedUpdateList.ToArray();
-
-			for (int i = 0; i < arrayCopy.Length; i++)
+			// Iterate backwards to allow safe mutation during iteration
+			for (int i = _onFixedUpdateList.Count - 1; i >= 0; i--)
 			{
-				arrayCopy[i].Action(Time.fixedTime);
+				// Skip if the item was removed by a previous action
+				if (i >= _onFixedUpdateList.Count)
+				{
+					continue;
+				}
+
+				_onFixedUpdateList[i].Action(Time.fixedTime);
 			}
 		}
 
@@ -326,11 +331,16 @@ private void Update(List<TickData> list)
 				return;
 			}
 
-			var arrayCopy = list.ToArray();
-
-			for (int i = 0; i < arrayCopy.Length; i++)
+			// Iterate backwards to allow safe mutation during iteration
+			for (int i = list.Count - 1; i >= 0; i--)
 			{
-				var tickData = arrayCopy[i];
+				// Skip if the item was removed by a previous action
+				if (i >= list.Count)
+				{
+					continue;
+				}
+
+				var tickData = list[i];
 				var time = tickData.RealTime ? Time.realtimeSinceStartup : Time.time;
 
 				if (time < tickData.LastTickTime + tickData.DeltaTime)
@@ -339,19 +349,15 @@ private void Update(List<TickData> list)
 				}
 
 				var deltaTime = time - tickData.LastTickTime;
-				var countBefore = list.Count;
 
 				tickData.Action(deltaTime);
 
-				// Check if the update was not unsubscribed in the call
-				var index = i - (arrayCopy.Length - countBefore);
-				if (list.Count > index && tickData == list[index])
+				// Check if the item still exists and wasn't unsubscribed
+				if (i < list.Count && list[i] == tickData)
 				{
 					var overFlow = tickData.DeltaTime == 0 ? 0 : deltaTime % tickData.DeltaTime;
-
 					tickData.LastTickTime = tickData.TimeOverflowToNextTick ? time - overFlow : time;
-
-					list[index] = tickData;
+					list[i] = tickData;
 				}
 			}
 		}