Merge pull request #22 from CoderGamester/develop

Release 0.13.1

Author: CoderGamester

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.13.1] - 2024-11-04
+
+**Fixed**:
+- Fixed the *IInstaller* when trying to bind multiple interfaces at the same time
+
 ## [0.13.0] - 2024-11-04
 
 **Changed**:

Runtime/Installer.cs

@@ -36,7 +36,10 @@ public interface IInstaller
 		/// <returns>
 		/// This installer reference to allow chain calls if necessayr
 		/// </returns>
-		IInstaller Bind<T1, T2>(T1 instance) where T1 : class, T2;
+		IInstaller Bind<T, T1, T2>(T instance)
+			where T : class, T1, T2
+			where T1 : class
+			where T2 : class;
 
 		/// <summary>
 		/// Binds the interface multiple type interefaces to the given <paramref name="instance"/>
@@ -47,18 +50,11 @@ public interface IInstaller
 		/// <returns>
 		/// This installer reference to allow chain calls if necessayr
 		/// </returns>
-		IInstaller Bind<T1, T2, T3>(T1 instance) where T1 : class, T2, T3;
-
-		/// <summary>
-		/// Binds the interface multiple type interefaces to the given <paramref name="instance"/>
-		/// </summary>
-		/// <exception cref="ArgumentException">
-		/// Thrown if the given <paramref name="instance"/> doesn't implement all type interface
-		/// </exception>
-		/// <returns>
-		/// This installer reference to allow chain calls if necessayr
-		/// </returns>
-		IInstaller Bind<T1, T2, T3, T4>(T1 instance) where T1 : class, T2, T3, T4;
+		IInstaller Bind<T, T1, T2, T3>(T instance) 
+			where T : class, T1, T2, T3
+			where T1 : class
+			where T2 : class
+			where T3 : class;
 
 		/// <summary>
 		/// Tries requesting the instance binded to the type <typeparamref name="T"/>
@@ -109,88 +105,27 @@ public IInstaller Bind<T>(T instance) where T : class
 		}
 
 		/// <inheritdoc />
-		public IInstaller Bind<T1, T2>(T1 instance) where T1 : class, T2
-		{
-			var type1 = typeof(T1);
-			var type2 = typeof(T2);
-
-			if (!type1.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type1} is not an interface");
-			}
-
-			if (!type2.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type1} is not an interface");
-			}
-
-			_bindings.Add(type1, instance);
-			_bindings.Add(type2, instance);
-
-			return this;
-		}
-
-		/// <inheritdoc />
-		public IInstaller Bind<T1, T2, T3>(T1 instance) where T1 : class, T2, T3
+		public IInstaller Bind<T, T1, T2>(T instance)
+			where T : class, T1, T2
+			where T1 : class
+			where T2 : class
 		{
-			var type1 = typeof(T1);
-			var type2 = typeof(T2);
-			var type3 = typeof(T3);
-
-			if (!type1.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type1} is not an interface");
-			}
-
-			if (!type2.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type2} is not an interface");
-			}
-
-			if (!type3.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type3} is not an interface");
-			}
-
-			_bindings.Add(type1, instance);
-			_bindings.Add(type2, instance);
-			_bindings.Add(type3, instance);
+			Bind<T1>(instance);
+			Bind<T2>(instance);
 
 			return this;
 		}
 
 		/// <inheritdoc />
-		public IInstaller Bind<T1, T2, T3, T4>(T1 instance) where T1 : class, T2, T3, T4
+		public IInstaller Bind<T, T1, T2, T3>(T instance)
+			where T : class, T1, T2, T3
+			where T1 : class
+			where T2 : class
+			where T3 : class
 		{
-			var type1 = typeof(T1);
-			var type2 = typeof(T2);
-			var type3 = typeof(T3);
-			var type4 = typeof(T4);
-
-			if (!type1.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type1} is not an interface");
-			}
-
-			if (!type2.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type2} is not an interface");
-			}
-
-			if (!type3.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type3} is not an interface");
-			}
-
-			if (!type4.IsInterface)
-			{
-				throw new ArgumentException($"Cannot bind {instance} because {type4} is not an interface");
-			}
-
-			_bindings.Add(type1, instance);
-			_bindings.Add(type2, instance);
-			_bindings.Add(type3, instance);
-			_bindings.Add(type4, instance);
+			Bind<T1>(instance);
+			Bind<T2>(instance);
+			Bind<T3>(instance);
 
 			return this;
 		}

package.json

@@ -2,7 +2,7 @@
   "name": "com.gamelovers.services",
   "displayName": "Services",
   "author": "Miguel Tomas",
-  "version": "0.13.0",
+  "version": "0.13.1",
   "unity": "2022.3",
   "license": "MIT",
   "description": "The purpose of this package is to provide a set of services to ease the development of a basic game architecture",