Merge pull request #20 from CoderGamester/develop

Release 0.12.2

Author: CoderGamester

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.12.2] - 2024-11-02
+
+**Fixed**:
+- Fixed an inssue where *IPoolEntityObject<T>.Init()* wouldn't be called when spawning entities
+
 ## [0.12.1] - 2024-10-25
 
 **Fixed**:

Runtime/ObjectPool.cs

@@ -164,11 +164,7 @@ protected ObjectPoolBase(uint initSize, T sampleEntity, Func<T, T> instantiator)
 
 			for (var i = 0; i < initSize; i++)
 			{
-				var entity = instantiator.Invoke(SampleEntity);
-				var poolEntity = entity as IPoolEntityObject<T>;
-
-				poolEntity?.Init(this);
-				_stack.Push(entity);
+				_stack.Push(CallInstantiator());
 			}
 		}
 
@@ -274,7 +270,7 @@ protected virtual T SpawnEntity()
 
 			do
 			{
-				entity = _stack.Count == 0 ? _instantiator.Invoke(SampleEntity) : _stack.Pop();
+				entity = _stack.Count == 0 ? CallInstantiator() : _stack.Pop();
 			}
 			// Need to do while loop and check as parent objects could have destroyed the entity/gameobject before it could
 			// be properly disposed by pool service
@@ -287,6 +283,16 @@ protected virtual T SpawnEntity()
 
 		protected virtual void PostDespawnEntity(T entity) { }
 
+		protected T CallInstantiator()
+		{
+			var entity = _instantiator.Invoke(SampleEntity);
+			var poolEntity = entity as IPoolEntityObject<T>;
+
+			poolEntity?.Init(this);
+
+			return entity;
+		}
+
 		protected void CallOnSpawned(T entity)
 		{
 			var poolEntity = entity as IPoolEntitySpawn;

package.json

@@ -2,13 +2,13 @@
   "name": "com.gamelovers.services",
   "displayName": "Services",
   "author": "Miguel Tomas",
-  "version": "0.12.1",
-  "unity": "2022.4",
+  "version": "0.12.2",
+  "unity": "2022.3",
   "license": "MIT",
   "description": "The purpose of this package is to provide a set of services to ease the development of a basic game architecture",
   "type": "library",
   "hideInEditor": false,
   "dependencies": {
-    "com.gamelovers.dataextensions": "0.6.0"
+    "com.gamelovers.dataextensions": "0.6.2"
   }
 }