fix(menu): 修复菜单标题显示和窗口同步问题

- 更新版本号从 3.9.19 到 3.9.21
- 添加统一的标题格式化方法支持组件和颜色解析
- 修复 1.21.11+ 版本下副手槽位更新导致的崩溃问题
- 优化窗口接收器中的玩家视图验证逻辑
- 改进窗口属性更新时的安全检查机制
- 移除关闭窗口后的空悬引用防止内存泄漏

Author: YsGqHY

api/receptacle/src/main/kotlin/trplugins/menu/api/receptacle/vanilla/window/WindowListener.kt

@@ -106,7 +106,11 @@ object WindowListener {
         receptacle.callEventClick(evt)
         if (evt.isCancelled) {
             if (clickType == ReceptacleClickType.OFFHAND) {
-                nmsProxy<NMS>().sendWindowsSetSlot(player, windowId = 0, slot = 45)
+                if (MinecraftVersion.majorLegacy < 12111) {
+                    nmsProxy<NMS>().sendWindowsSetSlot(player, windowId = 0, slot = 45)
+                } else {
+                    nmsProxy<NMS>().sendWindowsSetSlot(player, slot = -1, windowId = -1)
+                }
             } else {
                 nmsProxy<NMS>().sendWindowsSetSlot(player, slot = -1, windowId = -1)
             }
@@ -129,4 +133,4 @@ object WindowListener {
             }
         }
     }
-}
+}

api/receptacle/src/main/kotlin/trplugins/menu/api/receptacle/vanilla/window/WindowReceptacle.kt

@@ -4,9 +4,11 @@ import org.bukkit.entity.Player
 import org.bukkit.inventory.ItemStack
 import taboolib.common.platform.function.submit
 import taboolib.module.chat.component
+import taboolib.module.nms.MinecraftVersion
 import taboolib.module.nms.nmsProxy
 import trplugins.menu.api.receptacle.Receptacle
 import trplugins.menu.api.receptacle.ReceptacleInteractEvent
+import trplugins.menu.api.receptacle.getViewingReceptacle
 import trplugins.menu.api.receptacle.setViewingReceptacle
 
 /**
@@ -47,8 +49,9 @@ open class WindowReceptacle(var type: WindowLayout, override var title: String =
 
     override fun setElement(element: ItemStack?, slot: Int, display: Boolean) {
         contents[slot] = element
-        if (!display || viewer == null) return
-        nmsProxy<NMS>().sendWindowsSetSlot(viewer!!, slot = slot, itemStack = element, stateId = stateId)
+        val player = viewer ?: return
+        if (!display || player.getViewingReceptacle() != this) return
+        nmsProxy<NMS>().sendWindowsSetSlot(player, slot = slot, itemStack = element, stateId = stateId)
     }
 
     override fun clear(display: Boolean) {
@@ -59,22 +62,22 @@ open class WindowReceptacle(var type: WindowLayout, override var title: String =
     }
 
     override fun refresh(slot: Int) {
-        if (viewer != null) {
-            setupPlayerInventorySlots()
-            runCatching {
-                if (slot >= 0) {
-                    nmsProxy<NMS>().sendWindowsSetSlot(viewer!!, slot = slot, itemStack = contents[slot], stateId = stateId)
-                } else {
-                    nmsProxy<NMS>().sendWindowsItems(viewer!!, items = contents)
-                }
+        val player = viewer ?: return
+        if (player.getViewingReceptacle() != this) return
+        setupPlayerInventorySlots()
+        runCatching {
+            if (slot >= 0) {
+                nmsProxy<NMS>().sendWindowsSetSlot(player, slot = slot, itemStack = contents[slot], stateId = stateId)
+            } else {
+                nmsProxy<NMS>().sendWindowsItems(player, items = contents)
             }
         }
     }
 
     override fun open(player: Player) {
         viewer = player
-        initializationPackets()
         player.setViewingReceptacle(this)
+        initializationPackets()
         onOpen(player, this)
     }
 
@@ -85,6 +88,7 @@ open class WindowReceptacle(var type: WindowLayout, override var title: String =
             }
             onClose(viewer!!, this)
             viewer!!.setViewingReceptacle(null)
+            viewer = null
         }
     }
 
@@ -98,9 +102,9 @@ open class WindowReceptacle(var type: WindowLayout, override var title: String =
     }
 
     override fun property(id: Int, value: Int) {
-        if (viewer != null) {
-            nmsProxy<NMS>().sendWindowsUpdateData(viewer!!, id = id, value = value)
-        }
+        val player = viewer ?: return
+        if (player.getViewingReceptacle() != this) return
+        nmsProxy<NMS>().sendWindowsUpdateData(player, id = id, value = value)
     }
 
     override fun callEventClick(event: ReceptacleInteractEvent<ItemStack>) {
@@ -112,7 +116,10 @@ open class WindowReceptacle(var type: WindowLayout, override var title: String =
     private fun initializationPackets() {
         if (viewer != null) {
             nmsProxy<NMS>().sendWindowsOpen(viewer!!, title = title, type = type)
-            nmsProxy<NMS>().sendWindowsSetSlot(viewer!!, windowId = 0, slot = 45)
+            if (MinecraftVersion.majorLegacy < 12111) {
+                // 1.21.11+ can crash on offhand slot update during menu switch
+                nmsProxy<NMS>().sendWindowsSetSlot(viewer!!, windowId = 0, slot = 45)
+            }
             refresh()
         }
     }

gradle.properties

@@ -1,2 +1,2 @@
 group=me.arasple.mc.trmenu
-version=3.9.19
+version=3.9.21

plugin/src/main/kotlin/trplugins/menu/api/action/impl/menu/SetTitle.kt

@@ -6,6 +6,8 @@ import trplugins.menu.api.action.ActionHandle
 import trplugins.menu.api.action.base.ActionBase
 import trplugins.menu.api.action.base.ActionContents
 import trplugins.menu.module.display.session
+import trplugins.menu.util.colorify
+import trplugins.menu.util.parseJson
 
 /**
  * TrMenu
@@ -25,10 +27,15 @@ class SetTitle(handle: ActionHandle) : ActionBase(handle) {
         val session = player.session()
         val receptacle = session.receptacle ?: return
         var title = contents.stringContent().parseContent(placeholderPlayer)
+        title = if (useComponent && runCatching { title.parseJson() }.isSuccess) {
+            title
+        } else {
+            title.colorify()
+        }
         if (useComponent) {
             title = title.component().build().toRawMessage()
         }
         receptacle.title(title)
     }
 
-}
+}

plugin/src/main/kotlin/trplugins/menu/module/display/Menu.kt

@@ -21,6 +21,8 @@ import trplugins.menu.module.display.layout.MenuLayout
 import trplugins.menu.module.internal.data.Metadata
 import trplugins.menu.module.internal.script.evalAction
 import trplugins.menu.module.internal.script.evalScript
+import trplugins.menu.util.colorify
+import trplugins.menu.util.parseJson
 import java.util.function.Consumer
 
 /**
@@ -168,9 +170,7 @@ class Menu(
                     loadTitle(session)
                 }
             } else {
-                val parseTitle = if (SetTitle.useComponent) {
-                    title.component().build().toRawMessage()
-                } else title
+                val parseTitle = formatTitle(title)
                 session.receptacle?.title(parseTitle, update = false)
             }
             if (BEDROCK_DELAY > 0 && PlatformProvider.isBedrockPlayer(viewer)) {
@@ -189,18 +189,12 @@ class Menu(
     private fun loadTitle(session: MenuSession) {
         val title = settings.title(session)
         session.receptacle?.title(title.next(session.id)?.let {
-            val parseTitle = session.parse(it)
-            if (SetTitle.useComponent) {
-                parseTitle.component().build().toRawMessage()
-            } else parseTitle
+            formatTitle(session.parse(it))
         } ?: pluginId, update = false)
 
         val setTitle = {
             session.receptacle?.title(title.next(session.id)?.let {
-                val parseTitle = session.parse(it)
-                if (SetTitle.useComponent) {
-                    parseTitle.component().build().toRawMessage()
-                } else parseTitle
+                formatTitle(session.parse(it))
             } ?: pluginId)
         }
 
@@ -211,6 +205,15 @@ class Menu(
         }
     }
 
+    private fun formatTitle(title: String): String {
+        val colored = if (SetTitle.useComponent && runCatching { title.parseJson() }.isSuccess) {
+            title
+        } else {
+            title.colorify()
+        }
+        return if (SetTitle.useComponent) colored.component().build().toRawMessage() else colored
+    }
+
     private fun loadIcon(session: MenuSession) {
         session.shutTemps()
         icons