old revert

Author: CoderOMaster

CONTRIBUTING.md

@@ -14,8 +14,7 @@ Most documentation is currently written in Markdown, making it easy to add, modi
 
 ## Issues
 
-Create new issues in the
-[issue tracker](https://github.com/EnAccess/OpenPAYGO-python/issues/new/choose)
+Issues are created [here](https://github.com/EnAccess/OpenPAYGO-python/issues/new/choose)
 
 ### How to Contribute to Issues
 

openpaygo/token_decode.py

@@ -134,8 +134,7 @@ def get_activation_value_count_and_type_from_token(
 
     @classmethod
     def _count_is_valid(cls, count, last_count, value, type, used_counts):
-        if used_counts is None:
-            used_counts = []
+
         if value == OpenPAYGOTokenShared.COUNTER_SYNC_VALUE:
             if count > (last_count - cls.MAX_TOKEN_JUMP):
                 return True
@@ -149,7 +148,7 @@ def _count_is_valid(cls, count, last_count, value, type, used_counts):
 
     @classmethod
     def update_used_counts(cls, past_used_counts, value, new_count, type):
-        if not past_used_counts: 
+        if not past_used_counts:
             return None
         highest_count = max(past_used_counts) if past_used_counts else 0
         if new_count > highest_count:

openpaygo/token_shared.py

@@ -61,32 +61,15 @@ def generate_starting_code(cls, key):
 
     @classmethod
     def load_secret_key_from_hex(cls, secret_key):
-        if isinstance(secret_key, (bytes, bytearray)):
-            secret_key_bytes = bytes(secret_key)
-            if len(secret_key_bytes) != 16:
-                raise ValueError(
-                    "The secret key provided is not correctly formatted, it should be "
-                    "16 "
-                    "bytes. "
-                )
-            return secret_key_bytes
 
         try:
-            decoded = codecs.decode(secret_key, "hex")
+            return codecs.decode(secret_key, "hex")
         except Exception:
             raise ValueError(
                 "The secret key provided is not correctly formatted, it should be 32 "
                 "hexadecimal characters. "
             )
 
-        if len(decoded) != 16:
-            raise ValueError(
-                "The secret key provided is not correctly formatted, it should be 32 "
-                "hexadecimal characters. "
-            )
-
-        return decoded
-
     @classmethod
     def _convert_to_29_5_bits(cls, source):
         mask = ((1 << (32 - 2 + 1)) - 1) << 2

test/README.md

@@ -3,15 +3,6 @@
 To run the test, first, create and activate a virtual environment. Then install the module and run the test:
 
 ```bash
-cd tests
-python -m venv env
-source env/bin/activate
-python -m pip install -e ..
-python simple_scenario_test.py
-```
-
-You can do it for full test procedure as well:
-
-```bash
-python full_test_procedure.py
+uv run python test/simple_scenario_test.py 
+uv run python test/full_test_procedure.py
 ```

test/simple_scenario_test.py

@@ -1,7 +1,7 @@
 from datetime import datetime, timedelta
 
-from test.simulators import DeviceSimulator, SingleDeviceServerSimulator
 from openpaygo.token_shared import TokenType
+from test.simulators import DeviceSimulator, SingleDeviceServerSimulator
 
 
 def assert_time_equals(time1, time2):