resolved changes

Author: CoderOMaster

openpaygo/metrics_shared.py

@@ -146,28 +146,10 @@ def generate_hash_string(cls, input_string, secret_key):
 
     @classmethod
     def load_secret_key_from_hex(cls, secret_key):
-        if isinstance(secret_key, (bytes, bytearray)):
-            secret_key_bytes = bytes(secret_key)
-            if len(secret_key_bytes) != 16:
-                raise ValueError(
-                    "The secret key provided is not correctly formatted, it should be "
-                    "16 "
-                    "bytes. "
-                )
-            return secret_key_bytes
-
         try:
-            decoded = codecs.decode(secret_key, "hex")
+            return codecs.decode(secret_key, "hex")
         except Exception:
             raise ValueError(
                 "The secret key provided is not correctly formatted, it should be 32 "
                 "hexadecimal characters. "
             )
-
-        if len(decoded) != 16:
-            raise ValueError(
-                "The secret key provided is not correctly formatted, it should be 32 "
-                "hexadecimal characters. "
-            )
-
-        return decoded

openpaygo/token_decode.py

@@ -149,7 +149,7 @@ def _count_is_valid(cls, count, last_count, value, type, used_counts):
 
     @classmethod
     def update_used_counts(cls, past_used_counts, value, new_count, type):
-        if past_used_counts is None:
+        if not past_used_counts: 
             return None
         highest_count = max(past_used_counts) if past_used_counts else 0
         if new_count > highest_count:

test/full_test_procedure.py

@@ -10,7 +10,7 @@
     test_name,
 )
 
-from openpaygo.simulators.device_simulator import DeviceSimulator
+from test.simulators.device_simulator import DeviceSimulator
 
 # This tests the device simulator against the full test procedure
 

test/simple_scenario_test.py

@@ -1,6 +1,6 @@
 from datetime import datetime, timedelta
 
-from openpaygo.simulators import DeviceSimulator, SingleDeviceServerSimulator
+from test.simulators import DeviceSimulator, SingleDeviceServerSimulator
 from openpaygo.token_shared import TokenType