Configure Rubocop

Author: kemenaran

.rubocop.yml

@@ -1,8 +1,22 @@
+plugins:
+  - rubocop-minitest
+  - rubocop-rake
+
 AllCops:
   TargetRubyVersion: 3.1
+  NewCops: enable
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
 Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/MethodLength:
+  CountAsOne: ['array', 'hash', 'heredoc', 'method_call']

Gemfile

@@ -10,3 +10,5 @@ gem "rake", "~> 13.0"
 gem "minitest", "~> 5.16"
 
 gem "rubocop", "~> 1.21"
+gem "rubocop-minitest", "~> 0.38", require: false
+gem "rubocop-rake", "~> 0.7", require: false

Gemfile.lock

@@ -58,6 +58,13 @@ GEM
     rubocop-ast (1.45.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
+    rubocop-minitest (0.38.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     tzinfo (2.0.6)
@@ -74,6 +81,8 @@ DEPENDENCIES
   minitest (~> 5.16)
   rake (~> 13.0)
   rubocop (~> 1.21)
+  rubocop-minitest (~> 0.38)
+  rubocop-rake (~> 0.7)
   siret_validator!
 
 BUNDLED WITH

lib/siret_validator.rb

@@ -2,7 +2,7 @@
 
 require "active_model"
 require "active_support/i18n"
-I18n.load_path += Dir[File.dirname(__FILE__) + "/locale/*.yml"]
+I18n.load_path += Dir["#{File.dirname(__FILE__)}/locale/*.yml"]
 
 module ActiveModel
   module Validations
@@ -81,4 +81,3 @@ def validates_siret_of(*attr_names)
     end
   end
 end
-

siret_validator.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |spec|
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/CodeursenLiberte/siret_validator"
   spec.metadata["changelog_uri"] = "https://github.com/CodeursenLiberte/siret_validator/blob/main/CHANGELOG.md"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

test/test_siret_validator.rb

@@ -19,28 +19,30 @@ def test_validate_siret
     Company.validates_siret_of(:siret)
 
     model = Company.new(siret: INVALID_SIRET)
+
     assert_predicate model, :invalid?
-    assert model.errors.has_key?(:siret)
+    assert model.errors.key?(:siret)
 
     model.siret = VALID_SIRET
+
     assert_predicate model, :valid?
-    refute model.errors.has_key?(:siret)
+    refute model.errors.key?(:siret)
   end
 
   def test_validate_siret_cases
     Company.validates_siret_of(:siret)
 
     cases = {
-      nil               => :wrong_siret_format, # nil
-      ""                => :wrong_siret_format, # blank
-      "8216114310003"   => :wrong_siret_format, # too short
-      "invalid--siret"  => :wrong_siret_format, # invalid characters
-      "82161143100031"  => nil,                 # valid siret
+      nil => :wrong_siret_format, # nil
+      "" => :wrong_siret_format, # blank
+      "8216114310003" => :wrong_siret_format, # too short
+      "invalid--siret" => :wrong_siret_format, # invalid characters
+      "82161143100031" => nil,                 # valid siret
       "821611431000314" => :wrong_siret_format, # too long
-      "82161143100039"  => :invalid,            # invalid luhn
-      "35600000000048"  => nil,                 # La Poste siège
-      "35600000041461"  => nil,                 # La Poste établissement
-      "35600000041462"  => :invalid             # invalid La Poste établissement
+      "82161143100039" => :invalid,            # invalid luhn
+      "35600000000048" => nil,                 # La Poste siège
+      "35600000041461" => nil,                 # La Poste établissement
+      "35600000041462" => :invalid             # invalid La Poste établissement
     }
 
     cases.each do |(siret, expected_error)|
@@ -70,27 +72,29 @@ def test_validate_siret_localized_message
     c = Company.new(siret: "foo")
 
     with_locale(:en) do
-      assert_equal c.tap(&:validate).errors[:siret], ["is the wrong length (should be 14 digits)"]
+      assert_equal ["is the wrong length (should be 14 digits)"], c.tap(&:validate).errors[:siret]
     end
 
     with_locale(:fr) do
-      assert_equal c.tap(&:validate).errors[:siret], ["ne fait pas la bonne longueur (doit comporter 14 chiffres)"]
+      assert_equal ["ne fait pas la bonne longueur (doit comporter 14 chiffres)"], c.tap(&:validate).errors[:siret]
     end
   end
 
   def test_validate_siret_with_custom_message
     Company.validates_siret_of(:siret, message: "is invalid")
 
     c = Company.new(siret: "foo").tap(&:validate)
-    assert_equal c.errors[:siret], ["is invalid"]
+
+    assert_equal ["is invalid"], c.errors[:siret]
   end
 
   private
 
   def assert_siret_validity(siret, expected_error)
     model = Company.new(siret: siret).tap(&:validate)
     if expected_error.present?
-      assert(model.errors.where(:siret, expected_error).present?, "Expected '#{siret}' to generate a ':#{expected_error}' validation error")
+      assert_predicate(model.errors.where(:siret, expected_error), :present?,
+                       "Expected '#{siret}' to generate a ':#{expected_error}' validation error")
     else
       assert_empty(model.errors[:siret], "Expected '#{siret}' to be valid")
     end