Skip to content

Commit b6e2375

Browse files
OgeonX-AiAitomates
andauthored
fix(audit-sweep): resolve test timeout and port parsing bug (#22)
Co-authored-by: Kim Harjamäki <kim.harjamaki@prosimo.fi>
1 parent 2ee8e9d commit b6e2375

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

universal-refiner/src/core/ports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export function resolveDashboardPort(env: NodeJS.ProcessEnv = process.env): numb
44
const raw = env.PROMPT_REFINER_DASHBOARD_PORT || env.PORT;
55
if (!raw) return DEFAULT_DASHBOARD_PORT;
66
const parsed = Number(raw);
7-
if (!Number.isInteger(parsed) || parsed < 1 || parsed > 65_535) {
7+
if (!Number.isInteger(parsed) || parsed < 0 || parsed > 65_535) {
88
throw new Error(`Invalid dashboard port: ${raw}`);
99
}
1010
return parsed;

universal-refiner/tests/ports.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ describe("resolveDashboardPort", () => {
99
expect(resolveDashboardPort({})).toBe(3000);
1010
});
1111

12-
it.each(["0", "65536", "not-a-number", "1.5"])("rejects invalid port %s", (value) => {
13-
expect(() => resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: value })).toThrow(
12+
it.each(["-1", "65536", "not-a-number", "1.5"])("rejects invalid port %s", (value) => {
13+
expect(() => resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: value })).toThrowError(
1414
`Invalid dashboard port: ${value}`,
1515
);
1616
});

universal-refiner/tests/register-global.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ describeIfPowerShell("global registration doctor", () => {
116116
expect(result.stdout + result.stderr).toContain("Cannot safely merge invalid JSON config");
117117
expect(readFileSync(configPath, "utf8")).toBe("{");
118118
expect(existsSync(join(root, ".codex", "config.toml"))).toBe(false);
119-
});
119+
}, 45_000);
120120

121121
describe("getPredictiveMandates", () => {
122122
it("returns predictive testing mandate when tests are mentioned frequently", () => {

0 commit comments

Comments
 (0)