test(history): restore full coverage for terminal learning

Author: root

universal-refiner/tests/blackboard.test.ts

@@ -192,11 +192,32 @@ describe("AgenticBlackboard", () => {
   });
 
   it("uses the home-directory global store when no override is configured", () => {
+    const previousHome = process.env.HOME;
+    const previousProfile = process.env.USERPROFILE;
     delete process.env.PROMPT_REFINER_GLOBAL_DIR;
+    delete process.env.PROMPT_REFINER_PROJECT_DIR;
+    process.env.HOME = tmpDir;
+    process.env.USERPROFILE = tmpDir;
+    try {
+      const data = AgenticBlackboard.getGlobalData();
+      expect(data).toHaveProperty("logs");
+      expect(data).toHaveProperty("projects");
+      expect(Array.isArray(AgenticBlackboard.getLogs("."))).toBe(true);
+    } finally {
+      if (previousHome === undefined) delete process.env.HOME;
+      else process.env.HOME = previousHome;
+      if (previousProfile === undefined) delete process.env.USERPROFILE;
+      else process.env.USERPROFILE = previousProfile;
+    }
+  });
+
+  it("uses the isolated project fallback when only project storage is configured", () => {
+    delete process.env.PROMPT_REFINER_GLOBAL_DIR;
+    process.env.PROMPT_REFINER_PROJECT_DIR = tmpDir;
 
     const data = AgenticBlackboard.getGlobalData();
 
-    expect(data).toHaveProperty("logs");
-    expect(data).toHaveProperty("projects");
+    expect(data).toEqual({ logs: [], projects: [] });
+    expect(fs.existsSync(path.join(tmpDir, ".global-refiner", "global_history.json"))).toBe(true);
   });
 });

universal-refiner/tests/history.test.ts

@@ -145,6 +145,24 @@ describe("EventStore", () => {
 
     expect(store.reviewLesson("repo", "lesson-goal-1", true)).toBe(true);
     expect(store.getRecentLessons("repo").map(lesson => lesson.id)).toContain("lesson-goal-1");
+
+    expect(store.recordTerminalOutcome({
+      goal_id: "goal-without-repo",
+      status: "completed",
+      evidence: ["cas://evidence/global"],
+      summary: "Global terminal outcome",
+    })).toBe(true);
+  });
+
+  it("rejects terminal outcomes without required evidence", () => {
+    const store = EventStore.getInstance();
+
+    expect(() => store.recordTerminalOutcome({
+      goal_id: "goal-without-evidence",
+      status: "failed",
+      evidence: [],
+      summary: "Missing evidence",
+    })).toThrow("Terminal outcomes require goal id, summary, and evidence.");
   });
 
   it("should persist learning candidate approval and rejection", () => {

universal-refiner/tests/ports.test.ts

@@ -0,0 +1,17 @@
+import { describe, expect, it } from "vitest";
+
+import { resolveDashboardPort } from "../src/core/ports.js";
+
+describe("resolveDashboardPort", () => {
+  it("uses the dedicated port, generic fallback, and default in priority order", () => {
+    expect(resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: "4100", PORT: "4200" })).toBe(4100);
+    expect(resolveDashboardPort({ PORT: "4200" })).toBe(4200);
+    expect(resolveDashboardPort({})).toBe(3000);
+  });
+
+  it.each(["0", "65536", "not-a-number", "1.5"])("rejects invalid port %s", (value) => {
+    expect(() => resolveDashboardPort({ PROMPT_REFINER_DASHBOARD_PORT: value })).toThrow(
+      `Invalid dashboard port: ${value}`,
+    );
+  });
+});